linux-kernel - [PATCH] ACPI: processor: Fix build when !CONFIG_HOTPLUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Mar 2021 12:26:30 +0200
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     linux-acpi@...r.kernel.org, "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     x86@...nel.org, Len Brown <lenb@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] ACPI: processor: Fix build when !CONFIG_HOTPLUG_CPU

Kernel test robot reports build breakage with commit 5f5e49e999ac
("ACPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()") when
!CONFIG_HOTPLUG_CPU/!CONFIG_SMP. wakeup_cpu0() is defined under
CONFIG_SMP and start_cpu0() under CONFIG_HOTPLUG_CPU which, in its turn,
depend on CONFIG_SMP. Add #ifdef CONFIG_HOTPLUG_CPU to the block, this
should be sufficient.

Reported-by: kernel test robot <lkp@...el.com>
Fixes: 5f5e49e999ac ("ACPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()")
Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
---
 drivers/acpi/processor_idle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index f0c73f658880..0925b1477230 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -539,7 +539,7 @@ static int acpi_idle_play_dead(struct cpuidle_device *dev, int index)
 		} else
 			return -ENODEV;
 
-#ifdef CONFIG_X86
+#if defined(CONFIG_X86) && defined(CONFIG_HOTPLUG_CPU)
 		/* If NMI wants to wake up CPU0, start CPU0. */
 		if (wakeup_cpu0())
 			start_cpu0();
-- 
2.30.2