linux-kernel - Re: [PATCH] hpsa: fix boot on ia64 (atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1wntpgxxr.fsf@ca-mkp.ca.oracle.com>
Date:   Mon, 29 Mar 2021 23:02:26 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
        Don.Brace@...rochip.com, Sergei Trofimovich <slyfox@...too.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-ia64@...r.kernel.org, storagedev@...rochip.com,
        linux-scsi <linux-scsi@...r.kernel.org>, jszczype@...hat.com,
        Scott.Benesh@...rochip.com, Scott.Teel@...rochip.com,
        thenzl@...hat.com,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH] hpsa: fix boot on ia64 (atomic_t alignment)

Arnd,

> I think Martin is still waiting for a fixed version of the patch, as
> the proposed patch from March 12 only solves the immediate symptom,
> but not the underlying problem of the CommandList structure being
> marked as unaligned. If it gets fixed, the new version should work on
> all architectures.

Yep.

I unfortunately don't have any hpsa adapters to test with. Was hoping
somebody with hardware would attempt to fix up the struct properly.

Given -rc5 we're running out of time so for 5.12 it's probably best if
we queue up the workaround. I would prefer an amalgamation of Don's and
Sergei's patches, though. I do like the assert so we can catch problems
early.

But really, somebody should fix this. While hpsa may be out of
commercial support, Linux will support the driver it until there are no
more users. And the current structure packing is just wrong.

-- 
Martin K. Petersen	Oracle Linux Engineering