[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK8P3a2AgboydhpHLMNBzdoHKULtZ5HTH2bjh2tBUGdDiVKCEA@mail.gmail.com>
Date: Tue, 30 Mar 2021 09:43:55 +0200
From: Arnd Bergmann <arnd@...nel.org>
To: Sergei Trofimovich <slyfox@...too.org>
Cc: "Martin K. Petersen" <martin.petersen@...cle.com>,
John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
Don Brace <don.brace@...rochip.com>,
linux-ia64@...r.kernel.org, storagedev@...rochip.com,
linux-scsi <linux-scsi@...r.kernel.org>, jszczype@...hat.com,
Scott Benesh <scott.benesh@...rochip.com>,
Scott Teel <scott.teel@...rochip.com>, thenzl@...hat.com,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide
On Tue, Mar 30, 2021 at 9:30 AM Arnd Bergmann <arnd@...nel.org> wrote:
> On Tue, Mar 30, 2021 at 9:22 AM Sergei Trofimovich <slyfox@...too.org> wrote:
>
> > @@ -451,7 +452,7 @@ struct CommandList {
> > bool retry_pending;
> > struct hpsa_scsi_dev_t *device;
> > atomic_t refcount; /* Must be last to avoid memset in hpsa_cmd_init() */
> > -} __aligned(COMMANDLIST_ALIGNMENT);
> > +} __packed __aligned(COMMANDLIST_ALIGNMENT);
>
> You are still marking CommandList as __packed here, which is
> what caused the original problem. Please don't mark this one
> as __packed at all. If there are individual members that you want
> to be misaligned inside of the structure, you could mark those
> explicitly.
Nevermind, I just got patch 2/3, splitting up the patches like this seems
fine to me.
Whole series
Reviewed-by: Arnd Bergmann <arnd@...db.de>
Powered by blists - more mailing lists