linux-kernel - Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu,  1 Apr 2021 23:54:48 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Scott Teel <scott.teel@...rochip.com>, jszczype@...hat.com,
        storagedev@...rochip.com, Don Brace <don.brace@...rochip.com>,
        Sergei Trofimovich <slyfox@...too.org>,
        John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
        Arnd Bergmann <arnd@...nel.org>,
        Scott Benesh <scott.benesh@...rochip.com>, thenzl@...hat.com,
        linux-ia64@...r.kernel.org, linux-scsi <linux-scsi@...r.kernel.org>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide

On Tue, 30 Mar 2021 08:19:56 +0100, Sergei Trofimovich wrote:

> Some of the structs contain `atomic_t` values and are not intended to be
> sent to IO controller as is.
> 
> The change adds __packed to every struct and union in the file.
> Follow-up commits will fix `atomic_t` problems.
> 
> The commit is a no-op at least on ia64:
>     $ diff -u <(objdump -d -r old.o) <(objdump -d -r new.o)

Applied to 5.12/scsi-fixes, thanks!

[1/3] hpsa: use __packed on individual structs, not header-wide
      https://git.kernel.org/mkp/scsi/c/5482a9a1a8fd
[2/3] hpsa: fix boot on ia64 (atomic_t alignment)
      https://git.kernel.org/mkp/scsi/c/02ec144292bc
[3/3] hpsa: add an assert to prevent from __packed reintroduction
      https://git.kernel.org/mkp/scsi/c/e01a00ff62ad

-- 
Martin K. Petersen	Oracle Linux Engineering