linux-kernel - Re: [PATCH v1 2/4] arm64: dts: imx8mq-nitrogen: add USB HOST support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d173681-7eb6-798f-7d9b-66a221625d34@pengutronix.de>
Date:   Tue, 30 Mar 2021 10:38:20 +0200
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Adrien Grassein <adrien.grassein@...il.com>
Cc:     devicetree@...r.kernel.org, will@...nel.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, linux-kernel@...r.kernel.org,
        krzk@...nel.org, bjorn.andersson@...aro.org, robh+dt@...nel.org,
        linux-imx@....com, kernel@...gutronix.de, catalin.marinas@....com,
        festevam@...il.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1 2/4] arm64: dts: imx8mq-nitrogen: add USB HOST support

Hello Adrien,

On 30.03.21 10:35, Adrien Grassein wrote:
> Add the description for the USB host port.
> At this time, the port will not work directly from the
> kernel because it's connected through a resettable hub
> that is not handle in the kernel. It should be controlled
> in the bootloader or in the userspace.

Couldn't you add a gpio-hog that gets the hub out of reset?

Cheers,
Ahmad

> 
> In the case of the Boundary's u-boot, this is done on the
> boot script:
> "
> starting USB...
> Bus usb@...00000: Register 2000140 NbrPorts 2
> Starting the controller
> USB XHCI 1.10
> Bus usb@...00000: Register 2000140 NbrPorts 2
> Starting the controller
> USB XHCI 1.10
> scanning bus usb@...00000 for devices... 1 USB Device(s) found
> scanning bus usb@...00000 for devices... 3 USB Device(s) found
> "
> 
> Signed-off-by: Adrien Grassein <adrien.grassein@...il.com>
> ---
>  .../boot/dts/freescale/imx8mq-nitrogen.dts    | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
> index b46f45a82be1..7a52e247c527 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
> @@ -213,6 +213,22 @@ &usb3_phy0 {
>  	status = "okay";
>  };
>  
> +&usb_dwc3_1 {
> +	dr_mode = "host";
> +	status = "okay";
> +};
> +
> +/*
> + * On this board, USB host is connected to a resettable hub.
> + * The reset signal is connected to the GPIO <&gpio1 14 GPIO_ACTIVE_LOW>.
> + * You need to activate it in the bootloader or in the userspace.
> + */
> +&usb3_phy1 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usb3_1>;
> +};
> +
>  &usdhc1 {
>  	assigned-clocks = <&clk IMX8MQ_CLK_USDHC1>;
>  	assigned-clock-rates = <400000000>;
> @@ -388,6 +404,12 @@ MX8MQ_IOMUXC_GPIO1_IO13_USB1_OTG_OC		0x16
>  		>;
>  	};
>  
> +	pinctrl_usb3_1: usb3-1grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_GPIO1_IO14_GPIO1_IO14		0x16
> +		>;
> +	};
> +
>  	pinctrl_usdhc1: usdhc1grp {
>  		fsl,pins = <
>  			MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK			0x83
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |