linux-kernel - Re: [PATCH v1 2/4] arm64: dts: imx8mq-nitrogen: add USB HOST support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABkfQAE_RkqGW5f6TkPJVGNZKOWVRr5LLTeRvWQuJ4riiR+SVw@mail.gmail.com>
Date:   Tue, 30 Mar 2021 10:54:47 +0200
From:   Adrien Grassein <adrien.grassein@...il.com>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc:     DTML <devicetree@...r.kernel.org>, will@...nel.org,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        bjorn.andersson@...aro.org, Rob Herring <robh+dt@...nel.org>,
        dl-linux-imx <linux-imx@....com>,
        Sascha Hauer <kernel@...gutronix.de>, catalin.marinas@....com,
        Fabio Estevam <festevam@...il.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1 2/4] arm64: dts: imx8mq-nitrogen: add USB HOST support

Hello Ahmad,

Le mar. 30 mars 2021 à 10:38, Ahmad Fatoum <a.fatoum@...gutronix.de> a écrit :
>
> Hello Adrien,
>
> On 30.03.21 10:35, Adrien Grassein wrote:
> > Add the description for the USB host port.
> > At this time, the port will not work directly from the
> > kernel because it's connected through a resettable hub
> > that is not handle in the kernel. It should be controlled
> > in the bootloader or in the userspace.
>
> Couldn't you add a gpio-hog that gets the hub out of reset?
>

Let's try, I didn't think about this solution ^^.

> Cheers,
> Ahmad
>
> >
> > In the case of the Boundary's u-boot, this is done on the
> > boot script:
> > "
> > starting USB...
> > Bus usb@...00000: Register 2000140 NbrPorts 2
> > Starting the controller
> > USB XHCI 1.10
> > Bus usb@...00000: Register 2000140 NbrPorts 2
> > Starting the controller
> > USB XHCI 1.10
> > scanning bus usb@...00000 for devices... 1 USB Device(s) found
> > scanning bus usb@...00000 for devices... 3 USB Device(s) found
> > "
> >
> > Signed-off-by: Adrien Grassein <adrien.grassein@...il.com>
> > ---
> >  .../boot/dts/freescale/imx8mq-nitrogen.dts    | 22 +++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
> > index b46f45a82be1..7a52e247c527 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
> > @@ -213,6 +213,22 @@ &usb3_phy0 {
> >       status = "okay";
> >  };
> >
> > +&usb_dwc3_1 {
> > +     dr_mode = "host";
> > +     status = "okay";
> > +};
> > +
> > +/*
> > + * On this board, USB host is connected to a resettable hub.
> > + * The reset signal is connected to the GPIO <&gpio1 14 GPIO_ACTIVE_LOW>.
> > + * You need to activate it in the bootloader or in the userspace.
> > + */
> > +&usb3_phy1 {
> > +     status = "okay";
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_usb3_1>;
> > +};
> > +
> >  &usdhc1 {
> >       assigned-clocks = <&clk IMX8MQ_CLK_USDHC1>;
> >       assigned-clock-rates = <400000000>;
> > @@ -388,6 +404,12 @@ MX8MQ_IOMUXC_GPIO1_IO13_USB1_OTG_OC              0x16
> >               >;
> >       };
> >
> > +     pinctrl_usb3_1: usb3-1grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_GPIO1_IO14_GPIO1_IO14              0x16
> > +             >;
> > +     };
> > +
> >       pinctrl_usdhc1: usdhc1grp {
> >               fsl,pins = <
> >                       MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK                 0x83
> >
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Thanks,
Adrien