linux-kernel - Re: [PATCH v5 5/9] soundwire: qcom: update register read/write routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YGLkA3p634eg9FDl@vkoul-mobl.Dlink>
Date:   Tue, 30 Mar 2021 14:10:35 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     yung-chuan.liao@...ux.intel.com,
        pierre-louis.bossart@...ux.intel.com, sanyog.r.kale@...el.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        robh@...nel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v5 5/9] soundwire: qcom: update register read/write
 routine

On 26-03-21, 06:39, Srinivas Kandagatla wrote:

> +	swrm->reg_write(swrm, SWRM_CMD_FIFO_WR_CMD, val);
> +
> +	/* version 1.3 or less */
> +	if (swrm->version <= 0x01030000)
> +		usleep_range(150, 155);
> +
> +	if (cmd_id == SWR_BROADCAST_CMD_ID) {
> +		/*
> +		 * sleep for 10ms for MSM soundwire variant to allow broadcast
> +		 * command to complete.
> +		 */
> +		ret = wait_for_completion_timeout(&swrm->broadcast,
> +						  msecs_to_jiffies(TIMEOUT_MS));
> +		if (!ret)
> +			ret = SDW_CMD_IGNORED;
> +		else
> +			ret = SDW_CMD_OK;
>  
> -	if (!ret) {
> -		ret = SDW_CMD_IGNORED;
> -		goto err;
>  	} else {
>  		ret = SDW_CMD_OK;
>  	}

Maybe add a comment here that we dont get status so write is assumed to
be OK

-- 
~Vinod