linux-kernel - Re: [PATCH v5 6/9] soundwire: qcom: add support to new interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YGLkmM4QCjkpg8/6@vkoul-mobl.Dlink>
Date:   Tue, 30 Mar 2021 14:13:04 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     yung-chuan.liao@...ux.intel.com,
        pierre-louis.bossart@...ux.intel.com, sanyog.r.kale@...el.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        robh@...nel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v5 6/9] soundwire: qcom: add support to new interrupts

On 26-03-21, 06:39, Srinivas Kandagatla wrote:

> -	ctrl->reg_write(ctrl, SWRM_INTERRUPT_CLEAR, sts);
> +	do {
> +		for (i = 0; i < SWRM_INTERRUPT_MAX; i++) {
> +			value = intr_sts_masked & (1 << i);

BIT(i) istead of shifiting?

> +			if (!value)
> +				continue;
> +
> +			switch (value) {
> +			case SWRM_INTERRUPT_STATUS_SLAVE_PEND_IRQ:
> +				devnum = qcom_swrm_get_alert_slave_dev_num(swrm);
> +				if (devnum < 0) {
> +					dev_err_ratelimited(swrm->dev,
> +					    "no slave alert found.spurious interrupt\n");
> +				} else {
> +					sdw_handle_slave_status(&swrm->bus, swrm->status);
> +				}
>  
> -	if (sts & SWRM_INTERRUPT_STATUS_SPECIAL_CMD_ID_FINISHED)
> -		complete(&ctrl->broadcast);
> +				break;
> +			case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED:
> +			case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS:
> +				dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n",
> +					__func__);

This should be debug
-- 
~Vinod