linux-kernel - Re: [PATCH -next] misc/pvpanic: fix return value check in pvpanic_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YGLvFTWjEAOfs3db@smile.fi.intel.com>
Date:   Tue, 30 Mar 2021 12:27:49 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Qiheng Lin <linqiheng@...wei.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mihai Carabas <mihai.carabas@...cle.com>,
        zhenwei pi <pizhenwei@...edance.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Joe Perches <joe@...ches.com>,
        Shile Zhang <shile.zhang@...ux.alibaba.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] misc/pvpanic: fix return value check in
 pvpanic_pci_probe()

On Tue, Mar 30, 2021 at 09:36:59AM +0800, Qiheng Lin wrote:
> In case of error, the function pci_iomap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.

Error path there is broken completely, this is only one place you fix, but I
suggest to switch to devm*, pcim* APIs instead,


-- 
With Best Regards,
Andy Shevchenko