linux-kernel - Re: [PATCH] mm/ksm: remove unused parameter from remove_trailing_rmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af93ede2-99c1-c5b5-e45e-641b807992a9@redhat.com>
Date:   Tue, 30 Mar 2021 11:27:46 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Chengyang Fan <cy.fan@...wei.com>, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/ksm: remove unused parameter from
 remove_trailing_rmap_items()

On 30.03.21 09:08, Chengyang Fan wrote:
> Since commit 6514d511dbe5 ("ksm: singly-linked rmap_list") was
> merged, remove_trailing_rmap_items() doesn't use the 'mm_slot'
> parameter. So remove it, and update caller accordingly.
> 
> Signed-off-by: Chengyang Fan <cy.fan@...wei.com>
> ---
>   mm/ksm.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/ksm.c b/mm/ksm.c
> index 9694ee2c71de..dd69f030c8c0 100644
> --- a/mm/ksm.c
> +++ b/mm/ksm.c
> @@ -817,8 +817,7 @@ static void remove_rmap_item_from_tree(struct rmap_item *rmap_item)
>   	cond_resched();		/* we're called from many long loops */
>   }
>   
> -static void remove_trailing_rmap_items(struct mm_slot *mm_slot,
> -				       struct rmap_item **rmap_list)
> +static void remove_trailing_rmap_items(struct rmap_item **rmap_list)
>   {
>   	while (*rmap_list) {
>   		struct rmap_item *rmap_item = *rmap_list;
> @@ -989,7 +988,7 @@ static int unmerge_and_remove_all_rmap_items(void)
>   				goto error;
>   		}
>   
> -		remove_trailing_rmap_items(mm_slot, &mm_slot->rmap_list);
> +		remove_trailing_rmap_items(&mm_slot->rmap_list);
>   		mmap_read_unlock(mm);
>   
>   		spin_lock(&ksm_mmlist_lock);
> @@ -2337,7 +2336,7 @@ static struct rmap_item *scan_get_next_rmap_item(struct page **page)
>   	 * Nuke all the rmap_items that are above this current rmap:
>   	 * because there were no VM_MERGEABLE vmas with such addresses.
>   	 */
> -	remove_trailing_rmap_items(slot, ksm_scan.rmap_list);
> +	remove_trailing_rmap_items(ksm_scan.rmap_list);
>   
>   	spin_lock(&ksm_mmlist_lock);
>   	ksm_scan.mm_slot = list_entry(slot->mm_list.next,
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb