linux-kernel - Re: [PATCH v5 09/19] gpio: support ROHM BD71815 GPOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vce8sUsVz0YgHLDFbVMEmbYzaUZ-nRwgOeEfDHowEnxrw@mail.gmail.com>
Date:   Tue, 30 Mar 2021 13:54:19 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-power <linux-power@...rohmeurope.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v5 09/19] gpio: support ROHM BD71815 GPOs

On Tue, Mar 30, 2021 at 1:43 PM Matti Vaittinen
<matti.vaittinen@...rohmeurope.com> wrote:
> On Tue, 2021-03-30 at 13:11 +0300, Andy Shevchenko wrote:

...

> Andy, how fatal do you think these issues are? I did put these comments
> on my 'things to clean-up' list.
>
> If you don't see them as fatal, then I rather not resend whole series
> of 19 patches just for these. I am anyway going to rework the ROHM PMIC
> GPIO drivers which I have authored during the next couple of months for
> regmap_gpio usage. This series has most of the acks except for the
> regulator part - so I was about to suggest to Lee that perhaps he could
> apply other but regulator stuff to MFD so I could squeeze the recipient
> list and amount of patches in series.

I understand that. I'm not a maintainer, but my personal view is that
it can be fixed in follow ups.
The problem as usual here is that people often forget to cook / send
follow up. That's why lately I'm more insisting on changes to be done
as soon as possible.

-- 
With Best Regards,
Andy Shevchenko