linux-kernel - Re: Fix hibernation in FIPS mode?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5524a2e-a405-e3a5-c68e-b74953a2f8a8@redhat.com>
Date:   Tue, 30 Mar 2021 10:51:47 -0400
From:   Chris von Recklinghausen <crecklin@...hat.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Dexuan Cui <decui@...rosoft.com>
Cc:     "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Fix hibernation in FIPS mode?

On 3/30/21 10:46 AM, Rafael J. Wysocki wrote:
> On Tue, Mar 30, 2021 at 12:14 AM Dexuan Cui <decui@...rosoft.com> wrote:
>> Hi,
>> MD5 was marked incompliant with FIPS in 2009:
>> a3bef3a31a19 ("crypto: testmgr - Skip algs not flagged fips_allowed in fips mode")
>> a1915d51e8e7 ("crypto: testmgr - Mark algs allowed in fips mode")
>>
>> But hibernation_e820_save() is still using MD5, and fails in FIPS mode
>> due to the 2018 patch:
>> 749fa17093ff ("PM / hibernate: Check the success of generating md5 digest before hibernation")
>>
>> As a result, hibernation doesn't work when FIPS is on.
>>
>> Do you think if hibernation_e820_save() should be changed to use a
>> FIPS-compliant algorithm like SHA-1?
> I would say yes, it should.


If we're not actually encrypting anything, shouldn't something like 
ghash work as well?


>
>> PS, currently it looks like FIPS mode is broken in the mainline:
>> https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg49414.html