[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210330151533.GA10067@quack2.suse.cz>
Date: Tue, 30 Mar 2021 17:15:33 +0200
From: Jan Kara <jack@...e.cz>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Theodore Ts'o <tytso@....edu>, Jan Kara <jack@...e.com>,
Arnd Bergmann <arnd@...db.de>,
Harshad Shirwadkar <harshadshirwadkar@...il.com>,
Mauricio Faria de Oliveira <mfo@...onical.com>,
Andreas Dilger <adilger@...ger.ca>,
Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
"zhangyi (F)" <yi.zhang@...wei.com>,
Alexander Lochmann <alexander.lochmann@...dortmund.de>,
Hui Su <sh_def@....com>, linux-ext4@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jbd2: avoid -Wempty-body warnings
On Mon 22-03-21 11:21:38, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> Building with 'make W=1' shows a harmless -Wempty-body warning:
>
> fs/jbd2/recovery.c: In function 'fc_do_one_pass':
> fs/jbd2/recovery.c:267:75: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 267 | jbd_debug(3, "Fast commit replay failed, err = %d\n", err);
> | ^
>
> Change the empty dprintk() macros to no_printk(), which avoids this
> warning and adds format string checking.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Sure. Feel free to add:
Reviewed-by: Jan Kara <jack@...e.cz>
Honza
> ---
> include/linux/jbd2.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 99d3cd051ac3..232e6285536a 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -61,7 +61,7 @@ void __jbd2_debug(int level, const char *file, const char *func,
> #define jbd_debug(n, fmt, a...) \
> __jbd2_debug((n), __FILE__, __func__, __LINE__, (fmt), ##a)
> #else
> -#define jbd_debug(n, fmt, a...) /**/
> +#define jbd_debug(n, fmt, a...) no_printk(fmt, ##a)
> #endif
>
> extern void *jbd2_alloc(size_t size, gfp_t flags);
> --
> 2.29.2
>
--
Jan Kara <jack@...e.com>
SUSE Labs, CR
Powered by blists - more mailing lists