[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YGvJ9vQftwVC9S7h@mit.edu>
Date: Mon, 5 Apr 2021 22:39:50 -0400
From: "Theodore Ts'o" <tytso@....edu>
To: Jan Kara <jack@...e.cz>
Cc: Arnd Bergmann <arnd@...nel.org>, Jan Kara <jack@...e.com>,
Arnd Bergmann <arnd@...db.de>,
Harshad Shirwadkar <harshadshirwadkar@...il.com>,
Mauricio Faria de Oliveira <mfo@...onical.com>,
Andreas Dilger <adilger@...ger.ca>,
Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
"zhangyi (F)" <yi.zhang@...wei.com>,
Alexander Lochmann <alexander.lochmann@...dortmund.de>,
Hui Su <sh_def@....com>, linux-ext4@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jbd2: avoid -Wempty-body warnings
On Tue, Mar 30, 2021 at 05:15:33PM +0200, Jan Kara wrote:
> On Mon 22-03-21 11:21:38, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > Building with 'make W=1' shows a harmless -Wempty-body warning:
> >
> > fs/jbd2/recovery.c: In function 'fc_do_one_pass':
> > fs/jbd2/recovery.c:267:75: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> > 267 | jbd_debug(3, "Fast commit replay failed, err = %d\n", err);
> > | ^
> >
> > Change the empty dprintk() macros to no_printk(), which avoids this
> > warning and adds format string checking.
> >
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Sure. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@...e.cz>
Applied, thanks.
- Ted
Powered by blists - more mailing lists