linux-kernel - Re: [PATCH] afs: fix no return statement in function returning non-void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Mar 2021 10:32:38 +0800
From:   Zheng Zengkai <zhengzengkai@...wei.com>
To:     <dhowells@...hat.com>, <linux-afs@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
CC:     <huawei.libin@...wei.com>
Subject: Re: [PATCH] afs: fix no return statement in function returning
 non-void

Hi David and Reviewers,

> Add missing return to fix following compilation issue:
>
> fs/afs/dir.c: In function ‘afs_dir_set_page_dirty’:
> fs/afs/dir.c:51:1: error: no return statement in function
> returning non-void [-Werror=return-type]
>
> Fixes: f3ddee8dc4e2 ("afs: Fix directory handling")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zheng Zengkai <zhengzengkai@...wei.com>
> ---
>   fs/afs/dir.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/fs/afs/dir.c b/fs/afs/dir.c
> index 17548c1faf02..1795a05b7cb7 100644
> --- a/fs/afs/dir.c
> +++ b/fs/afs/dir.c
> @@ -48,6 +48,7 @@ static void afs_dir_invalidatepage(struct page *page, unsigned int offset,
>   static int afs_dir_set_page_dirty(struct page *page)
>   {
>   	BUG(); /* This should never happen. */
> +	return 0;
>   }
>   
>   const struct file_operations afs_dir_file_operations = {

Is there anyone who can take a look?  ;-)

Thanks!