linux-kernel - Re: [PATCH] afs: fix no return statement in function returning non-void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6575.1617890815@warthog.procyon.org.uk>
Date:   Thu, 08 Apr 2021 15:06:55 +0100
From:   David Howells <dhowells@...hat.com>
To:     Zheng Zengkai <zhengzengkai@...wei.com>
Cc:     dhowells@...hat.com, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org, huawei.libin@...wei.com
Subject: Re: [PATCH] afs: fix no return statement in function returning non-void

Zheng Zengkai <zhengzengkai@...wei.com> wrote:

>  static int afs_dir_set_page_dirty(struct page *page)
>  {
>  	BUG(); /* This should never happen. */
> +	return 0;
>  }

That shouldn't be necessary.  BUG() should be marked as 'no return' to the
compiler.  What arch and compiler are you using?

David