Date:   Wed, 31 Mar 2021 09:20:12 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Kuo-Hsiang Chou <kuohsiang_chou@...eedtech.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     "airlied@...ux.ie" <airlied@...ux.ie>,
        Jenmin Yuan <jenmin_yuan@...eedtech.com>,
        Tommy Huang <tommy_huang@...eedtech.com>,
        Arc Sung <arc_sung@...eedtech.com>,
        "airlied@...hat.com" <airlied@...hat.com>
Subject: Re: [PATCH V3] drm/ast: Disable fast reset after DRAM initial

Hi

Am 31.03.21 um 08:56 schrieb Kuo-Hsiang Chou:
> Message-ID: <20201228030823.294147-1-kuohsiang_chou@...eedtech.com>
> 
> -----Original Message-----
> From: Thomas Zimmermann [mailto:tzimmermann@...e.de]
> Sent: Monday, March 29, 2021 5:17 PM
> To: Kuo-Hsiang Chou <kuohsiang_chou@...eedtech.com>; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org
> 
> Subject: Re: [PATCH V3] drm/ast: Disable fast reset after DRAM initial
> 
> Hi,
> 
> I cannot apply this patch. The error is shown below. Which tree do you use? Can you please move to drm-misc-next?
> 
> Applying: drm/ast: Disable fast reset after DRAM initial
> error: sha1 information is lacking or useless (drivers/gpu/drm/ast/ast_drv.h).
> error: could not build fake ancestor
> Patch failed at 0001 drm/ast: Disable fast reset after DRAM initial
> hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
> dim: ERROR: git apply-mbox failed
> 
> Hi, Thomas,
> 
> Thanks for the comments, I still use kernel_5.9. Yes, I will move to the latest version of drm-misc-next.
> The errors seem to be caused by a pending patch(Message-ID: <20201228030823.294147-1-kuohsiang_chou@...eedtech.com>).
> And I submitted current patch before reviewer result of pending patch(Message-ID: <20201228030823.294147-1-kuohsiang_chou@...eedtech.com>).
> 
> Please give an instruction how to works to next step.
> Continue waiting for the reviewer result, or move to kernel_5.12-rc1 and submit the pending patch again? Or other suggestions?

The official Linux kernel tree is always behind with new features. So 
for development, you'll need a tree for the rsp topic. For DRM graphics, 
this would usually be drm-misc-next. [1]

I already wanted to apply the patch as it is in v3. I suggest to simply 
rebase it on top of drm-misc-next and resubmit to the mailing list.

When you create the patch file, 'git format-patch' and 'git am' support 
the --base option. It allows to set an upstream commit id. This can be 
helpful when git tries to apply the patch file later on. Several of our 
automated tests also use the base ref when they test patchsets. See the 
manpage of 'git format-patch' for a description of --base. [2]

Best regards
Thomas

[1] git://anongit.freedesktop.org/drm/drm-misc
[2] https://git-scm.com/docs/git-format-patch

> Thanks!
> 
> Best Regards,
> 	Kuo-Hsiang Chou
> 
> Best regards
> Thomas
> 
> 
> Am 19.03.21 um 10:23 schrieb KuoHsiang Chou:
>> [Bug][AST2500]
>>
>> V1:
>> When AST2500 acts as stand-alone VGA so that DRAM and DVO
>> initialization have to be achieved by VGA driver with P2A (PCI to AHB) enabling.
>> However, HW suggests disable Fast reset mode after DRAM initializaton,
>> because fast reset mode is mainly designed for ARM ICE debugger.
>> Once Fast reset is checked as enabling, WDT (Watch Dog Timer) should
>> be first enabled to avoid system deadlock before disable fast reset mode.
>>
>> V2:
>> Use to_pci_dev() to get revision of PCI configuration.
>>
>> V3:
>> If SCU00 is not unlocked, just enter its password again.
>> It is unnecessary to clear AHB lock condition and restore WDT default
>> setting again, before Fast-reset clearing.
>>
>> Signed-off-by: KuoHsiang Chou <kuohsiang_chou@...eedtech.com>
>> ---
>>    drivers/gpu/drm/ast/ast_drv.h  |  1 +
>>    drivers/gpu/drm/ast/ast_main.c |  5 +++
>>    drivers/gpu/drm/ast/ast_post.c | 68 +++++++++++++++++++++-------------
>>    3 files changed, 48 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ast/ast_drv.h
>> b/drivers/gpu/drm/ast/ast_drv.h index da6dfb677540..a2cf5fef2399
>> 100644
>> --- a/drivers/gpu/drm/ast/ast_drv.h
>> +++ b/drivers/gpu/drm/ast/ast_drv.h
>> @@ -320,6 +320,7 @@ bool ast_is_vga_enabled(struct drm_device *dev);
>>    void ast_post_gpu(struct drm_device *dev);
>>    u32 ast_mindwm(struct ast_private *ast, u32 r);
>>    void ast_moutdwm(struct ast_private *ast, u32 r, u32 v);
>> +void ast_patch_ahb_2500(struct ast_private *ast);
>>    /* ast dp501 */
>>    void ast_set_dp501_video_output(struct drm_device *dev, u8 mode);
>>    bool ast_backup_fw(struct drm_device *dev, u8 *addr, u32 size); diff
>> --git a/drivers/gpu/drm/ast/ast_main.c
>> b/drivers/gpu/drm/ast/ast_main.c index 3775fe26f792..0e4dfcc25623
>> 100644
>> --- a/drivers/gpu/drm/ast/ast_main.c
>> +++ b/drivers/gpu/drm/ast/ast_main.c
>> @@ -69,6 +69,7 @@ static void ast_detect_config_mode(struct drm_device *dev, u32 *scu_rev)
>>    {
>>    	struct device_node *np = dev->pdev->dev.of_node;
>>    	struct ast_private *ast = to_ast_private(dev);
>> +	struct pci_dev *pdev = to_pci_dev(dev->dev);
>>    	uint32_t data, jregd0, jregd1;
>>
>>    	/* Defaults */
>> @@ -96,6 +97,10 @@ static void ast_detect_config_mode(struct drm_device *dev, u32 *scu_rev)
>>    	jregd0 = ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xd0, 0xff);
>>    	jregd1 = ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xd1, 0xff);
>>    	if (!(jregd0 & 0x80) || !(jregd1 & 0x10)) {
>> +		/* Patch AST2500 */
>> +		if (((pdev->revision & 0xF0) == 0x40) && ((jregd0 & 0xC0) == 0))
>> +			ast_patch_ahb_2500(ast);
>> +
>>    		/* Double check it's actually working */
>>    		data = ast_read32(ast, 0xf004);
>>    		if (data != 0xFFFFFFFF) {
>> diff --git a/drivers/gpu/drm/ast/ast_post.c
>> b/drivers/gpu/drm/ast/ast_post.c index 8902c2f84bf9..4f194c5fd2c2
>> 100644
>> --- a/drivers/gpu/drm/ast/ast_post.c
>> +++ b/drivers/gpu/drm/ast/ast_post.c
>> @@ -2026,6 +2026,30 @@ static bool ast_dram_init_2500(struct ast_private *ast)
>>    	return true;
>>    }
>>
>> +void ast_patch_ahb_2500(struct ast_private *ast) {
>> +	u32	data;
>> +
>> +	/* Clear bus lock condition */
>> +	ast_moutdwm(ast, 0x1e600000, 0xAEED1A03);
>> +	ast_moutdwm(ast, 0x1e600084, 0x00010000);
>> +	ast_moutdwm(ast, 0x1e600088, 0x00000000);
>> +	ast_moutdwm(ast, 0x1e6e2000, 0x1688A8A8);
>> +	data = ast_mindwm(ast, 0x1e6e2070);
>> +	if (data & 0x08000000) {					/* check fast reset */
>> +
>> +		ast_moutdwm(ast, 0x1E785004, 0x00000010);
>> +		ast_moutdwm(ast, 0x1E785008, 0x00004755);
>> +		ast_moutdwm(ast, 0x1E78500c, 0x00000033);
>> +		udelay(1000);
>> +	}
>> +	do {
>> +		ast_moutdwm(ast, 0x1e6e2000, 0x1688A8A8);
>> +		data = ast_mindwm(ast, 0x1e6e2000);
>> +	}	while (data != 1);
>> +	ast_moutdwm(ast, 0x1e6e207c, 0x08000000);	/* clear fast reset */
>> +}
>> +
>>    void ast_post_chip_2500(struct drm_device *dev)
>>    {
>>    	struct ast_private *ast = to_ast_private(dev); @@ -2033,39 +2057,31
>> @@ void ast_post_chip_2500(struct drm_device *dev)
>>    	u8 reg;
>>
>>    	reg = ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xd0, 0xff);
>> -	if ((reg & 0x80) == 0) {/* vga only */
>> +	if ((reg & 0xC0) == 0) {/* vga only */
>>    		/* Clear bus lock condition */
>> -		ast_moutdwm(ast, 0x1e600000, 0xAEED1A03);
>> -		ast_moutdwm(ast, 0x1e600084, 0x00010000);
>> -		ast_moutdwm(ast, 0x1e600088, 0x00000000);
>> -		ast_moutdwm(ast, 0x1e6e2000, 0x1688A8A8);
>> -		ast_write32(ast, 0xf004, 0x1e6e0000);
>> -		ast_write32(ast, 0xf000, 0x1);
>> -		ast_write32(ast, 0x12000, 0x1688a8a8);
>> -		while (ast_read32(ast, 0x12000) != 0x1)
>> -			;
>> -
>> -		ast_write32(ast, 0x10000, 0xfc600309);
>> -		while (ast_read32(ast, 0x10000) != 0x1)
>> -			;
>> +		ast_patch_ahb_2500(ast);
>> +
>> +		/* Disable watchdog */
>> +		ast_moutdwm(ast, 0x1E78502C, 0x00000000);
>> +		ast_moutdwm(ast, 0x1E78504C, 0x00000000);
>> +		/* Reset USB port */
>> +		ast_moutdwm(ast, 0x1E6E2090, 0x20000000);
>> +		ast_moutdwm(ast, 0x1E6E2094, 0x00004000);
>> +		if (ast_mindwm(ast, 0x1E6E2070) & 0x00800000) {
>> +			ast_moutdwm(ast, 0x1E6E207C, 0x00800000);
>> +			mdelay(100);
>> +			ast_moutdwm(ast, 0x1E6E2070, 0x00800000);
>> +		}
>> +		/* Modify eSPI reset pin */
>> +		temp = ast_mindwm(ast, 0x1E6E2070);
>> +		if (temp & 0x02000000)
>> +			ast_moutdwm(ast, 0x1E6E207C, 0x00004000);
>>
>>    		/* Slow down CPU/AHB CLK in VGA only mode */
>>    		temp = ast_read32(ast, 0x12008);
>>    		temp |= 0x73;
>>    		ast_write32(ast, 0x12008, temp);
>>
>> -		/* Reset USB port to patch USB unknown device issue */
>> -		ast_moutdwm(ast, 0x1e6e2090, 0x20000000);
>> -		temp  = ast_mindwm(ast, 0x1e6e2094);
>> -		temp |= 0x00004000;
>> -		ast_moutdwm(ast, 0x1e6e2094, temp);
>> -		temp  = ast_mindwm(ast, 0x1e6e2070);
>> -		if (temp & 0x00800000) {
>> -			ast_moutdwm(ast, 0x1e6e207c, 0x00800000);
>> -			mdelay(100);
>> -			ast_moutdwm(ast, 0x1e6e2070, 0x00800000);
>> -		}
>> -
>>    		if (!ast_dram_init_2500(ast))
>>    			drm_err(dev, "DRAM init failed !\n");
>>
>> --
>> 2.18.4
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@...ts.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>>
> 
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)

Powered by blists - more mailing lists