linux-kernel - RE: [PATCH v4 2/2] scsi: ufs: Fix wrong Task Tag used in task management request UPIUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 01 Apr 2021 15:44:19 +0900
From:   Daejun Park <daejun7.park@...sung.com>
To:     "cang@...eaurora.org" <cang@...eaurora.org>
CC:     ALIM AKHTAR <alim.akhtar@...sung.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "avri.altman@....com" <avri.altman@....com>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "hongwus@...eaurora.org" <hongwus@...eaurora.org>,
        "jaegeuk@...nel.org" <jaegeuk@...nel.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "kernel-team@...roid.com" <kernel-team@...roid.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "nguyenb@...eaurora.org" <nguyenb@...eaurora.org>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "sthumma@...eaurora.org" <sthumma@...eaurora.org>,
        "vinholikatti@...il.com" <vinholikatti@...il.com>,
        "ygardi@...eaurora.org" <ygardi@...eaurora.org>
Subject: RE: [PATCH v4 2/2] scsi: ufs: Fix wrong Task Tag used in task
 management request UPIUs

Hi, Can Guo

> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
...
>  
>  	req->end_io_data = &wait;
> -	free_slot = req->tag;
>  	WARN_ON_ONCE(free_slot < 0 || free_slot >= hba->nutmrs);
I think this line should be removed.

Thanks,
Daejun