linux-kernel - Re: [PATCH v4 2/2] scsi: ufs: Fix wrong Task Tag used in task management request UPIUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f49aadb6083a0e4623e06dcc4b07acde@codeaurora.org>
Date:   Thu, 01 Apr 2021 15:17:46 +0800
From:   Can Guo <cang@...eaurora.org>
To:     daejun7.park@...sung.com
Cc:     ALIM AKHTAR <alim.akhtar@...sung.com>, asutoshd@...eaurora.org,
        avri.altman@....com, beanhuo@...ron.com, hongwus@...eaurora.org,
        jaegeuk@...nel.org, jejb@...ux.ibm.com, kernel-team@...roid.com,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        martin.petersen@...cle.com, nguyenb@...eaurora.org,
        stanley.chu@...iatek.com, sthumma@...eaurora.org,
        vinholikatti@...il.com, ygardi@...eaurora.org
Subject: Re: [PATCH v4 2/2] scsi: ufs: Fix wrong Task Tag used in task
 management request UPIUs

On 2021-04-01 14:44, Daejun Park wrote:
> Hi, Can Guo
> 
>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> ...
>> 
>>  	req->end_io_data = &wait;
>> -	free_slot = req->tag;
>>  	WARN_ON_ONCE(free_slot < 0 || free_slot >= hba->nutmrs);
> I think this line should be removed.
> 

Oh, yes, will remove it in next version.

Thanks,
Can Guo.

> Thanks,
> Daejun