linux-kernel - Re: [PATCH] iio: adc: bcm_iproc_adc: Use %s and __func_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Apr 2021 11:30:15 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Mugilraj Dhavachelvan <dmugil2000@...il.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        linux-iio <linux-iio@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: bcm_iproc_adc: Use %s and __func__

On Thu, 1 Apr 2021 12:24:50 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Thu, Apr 1, 2021 at 9:27 AM Mugilraj Dhavachelvan
> <dmugil2000@...il.com> wrote:
> >
> > Change function's name to %s and __func__ to fix checkpatch.pl errors.  
> 
> No, just drop the __func__ completely. First of all, we have a device
> name, and uniqueness of the messages in the driver should guarantee
> easy findings. Second, specific to _dbg() variants, with enabled
> Dynamic Debug it can be chosen at run time!
> 
> I recommend going through all drivers and drop __func__ near to
> dev_dbg() and pr_debug().
> 

Agreed.  Though beware that some maintainers will count this
as noise and get grumpy.

I'm fine with such patches for IIO.

Jonathan