linux-kernel - Re: [PATCH v2 2/2] iio: temperature: add driver support for ti tmp117

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d2bce88-1c23-a711-6a37-118173066ab5@metafoo.de>
Date:   Fri, 2 Apr 2021 10:14:47 +0200
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Puranjay Mohan <puranjay12@...il.com>
Cc:     Alexandru Ardelean <alexandru.ardelean@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Hartmut Knaack <knaack.h@....de>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] iio: temperature: add driver support for ti tmp117

On 4/1/21 11:36 AM, Andy Shevchenko wrote:
> [...]
>> +       case IIO_CHAN_INFO_SCALE:
>> +               /* Conversion from 10s of uC to mC
>> +                * as IIO reports temperature in mC
>> +                */
>> +               *val = TMP117_RESOLUTION_10UC / 10000;
>> +               *val2 = (TMP117_RESOLUTION_10UC % 10000) * 100;
>> +               return IIO_VAL_INT_PLUS_MICRO;
> You use 10000 many times, can you give it an appropriate name (via #define)?
#define TENTHOUSAND 10000 ;)