linux-kernel - Re: [PATCH v2 2/2] iio: temperature: add driver support for ti tmp117

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vfu6B=p7XRx6Ca2tiwVzSgs8YOuyvYJ63cOrYZxDOYdSg@mail.gmail.com>
Date:   Sat, 3 Apr 2021 16:52:34 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Lars-Peter Clausen <lars@...afoo.de>
Cc:     Puranjay Mohan <puranjay12@...il.com>,
        Alexandru Ardelean <alexandru.ardelean@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Hartmut Knaack <knaack.h@....de>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] iio: temperature: add driver support for ti tmp117

On Fri, Apr 2, 2021 at 11:14 AM Lars-Peter Clausen <lars@...afoo.de> wrote:
>
> On 4/1/21 11:36 AM, Andy Shevchenko wrote:
> > [...]
> >> +       case IIO_CHAN_INFO_SCALE:
> >> +               /* Conversion from 10s of uC to mC
> >> +                * as IIO reports temperature in mC
> >> +                */
> >> +               *val = TMP117_RESOLUTION_10UC / 10000;
> >> +               *val2 = (TMP117_RESOLUTION_10UC % 10000) * 100;
> >> +               return IIO_VAL_INT_PLUS_MICRO;
> > You use 10000 many times, can you give it an appropriate name (via #define)?
> #define TENTHOUSAND 10000 ;)

Actually, besides April fool's day, this can have a value if 1000 is
defined as mC _PER_uC or so.
Oh, wait. We have it already.

#define MILLIDEGREE_PER_DEGREE 1000





--
With Best Regards,
Andy Shevchenko