linux-kernel - Re: [PATCH 7/9] sched: Cgroup core-scheduling interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABk29NuhhwPgFm9HQs=CgpPMKAiqVn4kOACwwEeTYmBTbw03Uw@mail.gmail.com>
Date:   Thu, 1 Apr 2021 17:34:13 -0700
From:   Josh Don <joshdon@...gle.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Joel Fernandes <joel@...lfernandes.org>,
        "Hyser,Chris" <chris.hyser@...cle.com>,
        Ingo Molnar <mingo@...nel.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Valentin Schneider <valentin.schneider@....com>,
        Mel Gorman <mgorman@...e.de>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Tejun Heo <tj@...nel.org>, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 7/9] sched: Cgroup core-scheduling interface

Thanks, allowing for multiple group cookies in a hierarchy is a nice
improvement.

> +               if (tgi != tg) {
> +                       if (tgi->core_cookie || (tgi->core_parent && tgi->core_parent != tg))
> +                               continue;
> +
> +                       tgi->core_parent = parent;
> +                       tgi->core_cookie = 0;

core_cookie must already be 0, given the check above.