linux-kernel - Re: [PATCH] ASoC: max98390: Add controls for tx path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210402152326.GA5402@sirena.org.uk>
Date:   Fri, 2 Apr 2021 16:23:26 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Steve Lee <steves.lee@...imintegrated.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        ckeepax@...nsource.cirrus.com, geert@...ux-m68k.org,
        rf@...nsource.wolfsonmicro.com, shumingf@...ltek.com,
        srinivas.kandagatla@...aro.org, krzk@...nel.org, dmurphy@...com,
        jack.yu@...ltek.com, nuno.sa@...log.com,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        ryan.lee.maxim@...il.com, steves.lee.maxim@...il.com
Subject: Re: [PATCH] ASoC: max98390: Add controls for tx path

On Fri, Apr 02, 2021 at 12:36:43PM +0900, Steve Lee wrote:

> +	SOC_SINGLE("Tx Enable Selection", MAX98390_PCM_TX_EN_A,
> +		0, 255, 0),

I'm not clear what this is (especially given the source selection below)
but it looks like it should be a mute control?

> +	SOC_SINGLE("Tx Hiz Selection", MAX98390_PCM_TX_HIZ_CTRL_A,
> +		0, 255, 0),

This I'd expect to be tied into machine driver configuration, either DT
properties or TDM slot configuration - it's not something that looks
like it's something you'd want to control at runtime.

> +	SOC_SINGLE("Tx Source Selection", MAX98390_PCM_CH_SRC_2,
> +		0, 255, 0),

This looks like it should be a DAPM control or possibly a TDM slot
configuration - look at how the Arizona devices handle routing from
multiple TDM slots for the DAPM version.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)