lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 3 Apr 2021 01:33:54 +0000 From: Steve Lee <SteveS.Lee@...imintegrated.com> To: Mark Brown <broonie@...nel.org> CC: "lgirdwood@...il.com" <lgirdwood@...il.com>, "perex@...ex.cz" <perex@...ex.cz>, "tiwai@...e.com" <tiwai@...e.com>, "ckeepax@...nsource.cirrus.com" <ckeepax@...nsource.cirrus.com>, "geert@...ux-m68k.org" <geert@...ux-m68k.org>, "rf@...nsource.wolfsonmicro.com" <rf@...nsource.wolfsonmicro.com>, "shumingf@...ltek.com" <shumingf@...ltek.com>, "srinivas.kandagatla@...aro.org" <srinivas.kandagatla@...aro.org>, "krzk@...nel.org" <krzk@...nel.org>, "dmurphy@...com" <dmurphy@...com>, "jack.yu@...ltek.com" <jack.yu@...ltek.com>, "nuno.sa@...log.com" <nuno.sa@...log.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>, "ryan.lee.maxim@...il.com" <ryan.lee.maxim@...il.com>, "steves.lee.maxim@...il.com" <steves.lee.maxim@...il.com> Subject: RE: [EXTERNAL] Re: [PATCH] ASoC: max98390: Add controls for tx path > -----Original Message----- > From: Mark Brown <broonie@...nel.org> > Sent: Saturday, April 3, 2021 12:23 AM > To: Steve Lee <SteveS.Lee@...imintegrated.com> > Cc: lgirdwood@...il.com; perex@...ex.cz; tiwai@...e.com; > ckeepax@...nsource.cirrus.com; geert@...ux-m68k.org; > rf@...nsource.wolfsonmicro.com; shumingf@...ltek.com; > srinivas.kandagatla@...aro.org; krzk@...nel.org; dmurphy@...com; > jack.yu@...ltek.com; nuno.sa@...log.com; linux-kernel@...r.kernel.org; > alsa-devel@...a-project.org; ryan.lee.maxim@...il.com; > steves.lee.maxim@...il.com > Subject: [EXTERNAL] Re: [PATCH] ASoC: max98390: Add controls for tx path > > On Fri, Apr 02, 2021 at 12:36:43PM +0900, Steve Lee wrote: > > > + SOC_SINGLE("Tx Enable Selection", MAX98390_PCM_TX_EN_A, > > + 0, 255, 0), > > I'm not clear what this is (especially given the source selection below) but it > looks like it should be a mute control? Yes, each channel of enable and disable control. I will update this also configured by TDM slot configuration. > > > + SOC_SINGLE("Tx Hiz Selection", MAX98390_PCM_TX_HIZ_CTRL_A, > > + 0, 255, 0), > > This I'd expect to be tied into machine driver configuration, either DT properties > or TDM slot configuration - it's not something that looks like it's something > you'd want to control at runtime. I will update this with either TDM slot configuration and DT properties. > > > + SOC_SINGLE("Tx Source Selection", MAX98390_PCM_CH_SRC_2, > > + 0, 255, 0), > > This looks like it should be a DAPM control or possibly a TDM slot configuration - > look at how the Arizona devices handle routing from multiple TDM slots for the > DAPM version. This is for Current Sensing and Voltage sensing slot selection. I will update this as DT properties.
Powered by blists - more mailing lists