linux-kernel - Re: [PATCH v1 1/2] iio: trigger: Replace explicit casting and wrong specifier with proper one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcriL=Hei-UBJ2TT0ZDBq=n=cqd=z3Svob+LRauhFWhOg@mail.gmail.com>
Date:   Fri, 2 Apr 2021 20:45:55 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v1 1/2] iio: trigger: Replace explicit casting and wrong
 specifier with proper one

On Fri, Apr 2, 2021 at 4:25 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Friday, April 2, 2021, Jonathan Cameron <jic23@...nel.org> wrote:
>> On Thu,  1 Apr 2021 17:54:56 +0300
>> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
>>
>> > By unknown reason device name is set with an index casted from int
>> > to unsigned long while at the same time with "%ld" specifier. Both parts
>> > seems wrong to me, thus replace replace explicit casting and wrong specifier
>> > with proper one, i.e. "%u".
>> I'm not going to pretend to know what planet I was on when I wrote this :)
>
>
> Actually “%d” is even more correct (aligned with the type), but either will work.

I have noticed a typo in the commit message of the other patch.
I'll send a v2 altogether.

>> Series applied to the togreg branch of iio.git and pushed out as testing
>> for the autobuilders to poke at.


-- 
With Best Regards,
Andy Shevchenko