linux-kernel - Re: [PATCH v1 0/2] Add imx8m power domain driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABkfQAH+Gvu69UeDbxBGyQ1GroYuEqmrYFbkNE-qaLM2zpGRfQ@mail.gmail.com>
Date:   Fri, 2 Apr 2021 19:48:41 +0200
From:   Adrien Grassein <adrien.grassein@...il.com>
To:     Abel Vesa <abel.vesa@....com>
Cc:     Rob Herring <robh+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, arnd@...db.de,
        peng.fan@....com, Anson.Huang@....com,
        DTML <devicetree@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 0/2] Add imx8m power domain driver

Hi,

Le ven. 2 avr. 2021 à 19:42, Abel Vesa <abel.vesa@....com> a écrit :
>
> On 21-04-02 18:45:04, Adrien Grassein wrote:
> > Hi,
> >
> > this patch et aims to add the support of the i.MX 8 Power Domain driver.
> > Some devices (like usbotg2) can't work without this patch as their
> > attached power domain are down.
> >
> > The original drivr was taken from le imx kernel and aapted to fit with
> > the actual mainline (minor fixes).
> >
> > Thanks,
> >
>
> Big NACK for the whole series.
>
> This approach has already been rejected upstream.

So what is the correct approach?
At this point otg2 node of imx8mm is not working at all (and blocks the whole
boot of the kernel)

>
> Plus, you changed the original author, this work was originally done by Jacky Bai.

I have not changed this, the original author is not mentioned on the
original patch.
(Taken from https://github.com/Freescale/linux-fslc branch 5.4-2.2.x-imx)

>
> > Adrien Grassein (2):
> >   dt-bindings: power: Add documentation for imx8m power domain driver
> >   soc: imx: add Power Domain driver for i.MX8M(M|N|P)
> >
> >  .../bindings/power/fsl,imx-power-domain.yaml  |  89 +++++++
> >  MAINTAINERS                                   |  10 +
> >  drivers/soc/imx/Kconfig                       |   7 +
> >  drivers/soc/imx/Makefile                      |   1 +
> >  drivers/soc/imx/imx8m_pm_domains.c            | 233 ++++++++++++++++++
> >  include/dt-bindings/power/imx8mm-power.h      |  21 ++
> >  include/dt-bindings/power/imx8mn-power.h      |  15 ++
> >  include/dt-bindings/power/imx8mp-power.h      |  28 +++
> >  include/soc/imx/imx_sip.h                     |  12 +
> >  9 files changed, 416 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml
> >  create mode 100644 drivers/soc/imx/imx8m_pm_domains.c
> >  create mode 100644 include/dt-bindings/power/imx8mm-power.h
> >  create mode 100644 include/dt-bindings/power/imx8mn-power.h
> >  create mode 100644 include/dt-bindings/power/imx8mp-power.h
> >  create mode 100644 include/soc/imx/imx_sip.h
> >
> > --
> > 2.25.1
> >

Thanks,