linux-kernel - Re: [PATCH v3] net: tun: set tun->dev->addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdf3dcac-38d8-e63f-d43a-029a9742ec4d@gmail.com>
Date:   Tue, 6 Apr 2021 22:31:56 +0200
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Phillip Potter <phil@...lpotter.co.uk>, davem@...emloft.net
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] net: tun: set tun->dev->addr_len during TUNSETLINK
 processing



On 4/6/21 7:45 PM, Phillip Potter wrote:
> When changing type with TUNSETLINK ioctl command, set tun->dev->addr_len
> to match the appropriate type, using new tun_get_addr_len utility function
> which returns appropriate address length for given type. Fixes a
> KMSAN-found uninit-value bug reported by syzbot at:
> https://syzkaller.appspot.com/bug?id=0766d38c656abeace60621896d705743aeefed51
> 
> Reported-by: syzbot+001516d86dbe88862cec@...kaller.appspotmail.com
> Diagnosed-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
> ---

SGTM, thanks a lot.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>