linux-kernel - RE: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB44414602F10C6C991A65D48CE3769@DM6PR11MB4441.namprd11.prod.outlook.com>
Date:   Tue, 6 Apr 2021 08:17:42 +0000
From:   Pho Tran <Pho.Tran@...abs.com>
To:     'Greg KH' <gregkh@...uxfoundation.org>,
        'Pho Tran' <photranvan0712@...il.com>
CC:     "'johan@...nel.org'" <johan@...nel.org>,
        "'linux-usb@...r.kernel.org'" <linux-usb@...r.kernel.org>,
        "'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
        Hung Nguyen <Hung.Nguyen@...abs.com>,
        Tung Pham <Tung.Pham@...abs.com>,
        'Kernel test robot' <lkp@...el.com>
Subject: RE: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

Hi Greg!
I am grateful for your promptly reply!
 Yesterday, I got the response from the kernel test robot with this message: 
" If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>". 
It's a reason why I added "Reported-by: kernel test robot <lkp@...el.com>" 
to my new Patch.
Could you tell me what I need to do in the next step to submit this patch to the kernel mainline?
Once again, Thank you a lot!

-----Original Message-----
From: Greg KH <gregkh@...uxfoundation.org> 
Sent: Tuesday, April 6, 2021 12:15 PM
To: Pho Tran <photranvan0712@...il.com>
Cc: johan@...nel.org; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; Hung Nguyen <Hung.Nguyen@...abs.com>; Tung Pham <Tung.Pham@...abs.com>; Pho Tran <Pho.Tran@...abs.com>; Kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.


On Tue, Apr 06, 2021 at 11:02:38AM +0700, Pho Tran wrote:
> From: Pho Tran <pho.tran@...abs.com>
>
> Similar to other CP210x devices, GPIO interfaces (gpiochip) should be 
> supported for CP2108.
>
> CP2108 has 4 serial interfaces but only 1 set of GPIO pins are shared 
> to all of those interfaces. So, just need to initialize GPIOs of 
> CP2108 with only one interface (I use interface 0). It means just only 
> 1 gpiochip device file will be created for CP2108.
>
> CP2108 has 16 GPIOs, So data types of several variables need to be is 
> u16 instead of u8(in struct cp210x_serial_private). This doesn't 
> affect other CP210x devices.
>
> Because CP2108 has 16 GPIO pins, the parameter passed by cp210x 
> functions will be different from other CP210x devices. So need to 
> check part number of the device to use correct data format  before 
> sending commands to devices.
>
> Like CP2104, CP2108 have GPIO pins with configurable options. 
> Therefore, should be mask all pins which are not in GPIO mode in 
> cp2108_gpio_init() function.
>
> Fix build test WARNING reported by kernel test robot.
>
> Reported-by: Kernel test robot <lkp@...el.com>

The kernel test robot did not report this needed support :(