linux-kernel - Re: [PATCH v2] f2fs: fix the periodic wakeups of discard thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2197598-510b-dded-ffef-42203a101b1b@huawei.com>
Date:   Tue, 6 Apr 2021 17:29:46 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Sahitya Tummala <stummala@...eaurora.org>,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] f2fs: fix the periodic wakeups of discard thread

On 2021/4/6 17:09, Sahitya Tummala wrote:
> Fix the unnecessary periodic wakeups of discard thread that happens under
> below two conditions -
> 
> 1. When f2fs is heavily utilized over 80%, the current discard policy
> sets the max sleep timeout of discard thread as 50ms
> (DEF_MIN_DISCARD_ISSUE_TIME). But this is set even when there are
> no pending discard commands to be issued.
> 
> 2. In the issue_discard_thread() path when there are no pending discard
> commands, it fails to reset the wait_ms to max timeout value.
> 
> Signed-off-by: Sahitya Tummala <stummala@...eaurora.org>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,