linux-kernel - Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YG3X7ogK/Oq2Hv4J@smile.fi.intel.com>
Date:   Wed, 7 Apr 2021 19:03:58 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     kernel test robot <lkp@...el.com>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        kbuild-all@...ts.01.org, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the
 header

On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote:
> Hi Andy,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on block/for-next]
> [also build test ERROR on v5.12-rc6 next-20210407]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
> config: x86_64-randconfig-s021-20210407 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce:
>         # apt-get install sparse
>         # sparse version: v0.6.3-279-g6d5d9b42-dirty
>         # https://github.com/0day-ci/linux/commit/d2574103b692b4fc73f1ed36ee9e4d3324902fd9
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746
>         git checkout d2574103b692b4fc73f1ed36ee9e4d3324902fd9
>         # save the attached .config to linux build tree
>         make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):

Thanks, we need to include bits.h.
(It passed my simple build, but appears I have no such driver included)

Jens, I saw your message, should I send a follow up fix, or a v2?

>    In file included from drivers/hwmon/drivetemp.c:98:
>    include/linux/ata.h: In function 'ata_id_has_ncq_send_and_recv':
> >> include/linux/ata.h:929:40: error: implicit declaration of function 'BIT' [-Werror=implicit-function-declaration]
>      929 |  return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6);
>          |                                        ^~~
>    cc1: some warnings being treated as errors
> 
> 
> vim +/BIT +929 include/linux/ata.h
> 
> 4bca3286433585 Martin K. Petersen 2009-05-15  926  
> ed36911c747c18 Marc Carino        2013-08-24  927  static inline bool ata_id_has_ncq_send_and_recv(const u16 *id)
> ed36911c747c18 Marc Carino        2013-08-24  928  {
> ed36911c747c18 Marc Carino        2013-08-24 @929  	return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6);
> ed36911c747c18 Marc Carino        2013-08-24  930  }
> ed36911c747c18 Marc Carino        2013-08-24  931  
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org



-- 
With Best Regards,
Andy Shevchenko