linux-kernel - Re: [PATCH] selftests/resctrl: Change a few printed messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YG3n7gsIhqOGjltv@otcwcpicx3.sc.intel.com>
Date:   Wed, 7 Apr 2021 17:12:14 +0000
From:   Fenghua Yu <fenghua.yu@...el.com>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     Shuah Khan <shuah@...nel.org>,
        Ravi V Shankar <ravi.v.shankar@...el.com>,
        linux-kselftest <linux-kselftest@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] selftests/resctrl: Change a few printed messages

Hi, Shuah,

On Wed, Apr 07, 2021 at 08:33:23AM -0600, Shuah Khan wrote:
> On 4/5/21 6:52 PM, Fenghua Yu wrote:
> > -	ksft_print_msg("%s cache miss rate within %d%%\n",
> > -		       ret ? "Fail:" : "Pass:", max_diff_percent);
> > +	ksft_print_msg("Check cache miss rate within %d%%\n", max_diff_percent);
> 
> You need %s and pass in the ret ? "Fail:" : "Pass:" result for the
> message to read correctly.

Should I keep the ":" after "Pass"/"Fail"?

> 
> I am seeing:
> 
> # Check kernel support for resctrl filesystem
> 
> It should say the following:
> 
> # Fail Check kernel support for resctrl filesystem

i.e. should the printed messages be like the following?
# Fail: Check kernel support for resctrl filesystem
or
# Pass: Check kernel support for resctrl filesystem

Thanks.

-Fenghua