linux-kernel - Re: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif: Convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLgSjOxc8uoicSLE8nR=EKGpzK31CyHgdp5xarLtMV=9w@mail.gmail.com>
Date:   Wed, 7 Apr 2021 13:27:05 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
        Ramesh Shanmugasundaram <rashanmu@...il.com>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das.jz@...renesas.com>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
Subject: Re: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif: Convert
 to json-schema

On Thu, Jan 14, 2021 at 7:02 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Fabrizio, Rob,
>
> On Wed, Oct 21, 2020 at 3:53 PM Fabrizio Castro
> <fabrizio.castro.jz@...esas.com> wrote:
> > Convert the Renesas DRIF bindings to DT schema and update
> > MAINTAINERS accordingly.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > Reviewed-by: Rob Herring <robh@...nel.org>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
>
> > +  clock-names:
> > +    maxItems: 1
> > +    items:
> > +      - const: fck
>
> With latest dt-schema, "make dt_binding_check" complains:
>
>     Documentation/devicetree/bindings/media/renesas,drif.yaml:
> properties:clock-names:maxItems: False schema does not allow 1
>     Documentation/devicetree/bindings/media/renesas,drif.yaml:
> ignoring, error in schema: properties: clock-names: maxItems

Seems this just got applied, and now this error is in linux-next.

>
> Using
>
>        clock-names:
>          const: fck
>
> Fixes that.
>
> However, I'm wondering why I do not get a complaint about the similar
> clock/clock-names in
> Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml.
> Because they're part of an else branch?

Probably. if/then/else schemas have fewer checks as they can be
incomplete (only additional constraints on the top-level schema).

Rob