linux-kernel - Re: [PATCH v1 1/1] driver core: platform: Make platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Apr 2021 12:38:35 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Matthias Schiffer <matthias.schiffer@...tq-group.com>
Subject: Re: [PATCH v1 1/1] driver core: platform: Make
 platform_get_irq_optional() optional

On Tue, Apr 06, 2021 at 12:25:14PM -0700, Guenter Roeck wrote:
> On Wed, Mar 31, 2021 at 05:45:26PM +0300, Andy Shevchenko wrote:
> > Currently the platform_get_irq_optional() returns an error code even
> > if IRQ resource sumply has not been found. It prevents caller to be
> > error code agnostic in their error handling.
> > 
> > Now:
> > 	ret = platform_get_irq_optional(...);
> > 	if (ret != -ENXIO)
> > 		return ret; // respect deferred probe
> > 	if (ret > 0)
> > 		...we get an IRQ...
> > 
> > After proposed change:
> > 	ret = platform_get_irq_optional(...);
> > 	if (ret < 0)
> > 		return ret;
> > 	if (ret > 0)
> > 		...we get an IRQ...
> > 
> > Reported-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> This patch causes all my "sh" emulations to stall during boot with the
> following repeated error message.
> 
> sh-sci sh-sci.1: Can't allocate rx full IRQ
> 
> Reverting this patch fixes the problem (and the message is gone).
> Bisect log is attached.

I believe it reveals some "interesting" error handling there.
I'm going to propose a solution soon.

Thanks for the report!

-- 
With Best Regards,
Andy Shevchenko