| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Apr 2021 07:49:08 +0800
From: kernel test robot <lkp@...el.com>
To: Masahiro Yamada <masahiroy@...nel.org>,
linux-kbuild@...r.kernel.org
Cc: kbuild-all@...ts.01.org, linux-gpio@...r.kernel.org,
Arnd Bergmann <arnd@...db.de>,
Paul Cercueil <paul@...pouillou.net>,
Masahiro Yamada <masahiroy@...nel.org>,
Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/2] pm: allow drivers to drop #ifdef and __maybe_unused
from pm callbacks
Hi Masahiro,
I love your patch! Yet something to improve:
[auto build test ERROR on pinctrl/devel]
[also build test ERROR on pm/linux-next soc/for-next linus/master v5.12-rc6]
[cannot apply to next-20210408]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Masahiro-Yamada/linux-kconfig-h-move-IF_ENABLED-out-of-linux-kconfig-h/20210409-050128
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: nds32-randconfig-r004-20210408 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/01dfb9e1a54c14b3f491c3a5e93f1e8756042567
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Masahiro-Yamada/linux-kconfig-h-move-IF_ENABLED-out-of-linux-kconfig-h/20210409-050128
git checkout 01dfb9e1a54c14b3f491c3a5e93f1e8756042567
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
In file included from drivers/input/rmi4/rmi_spi.c:7:
drivers/input/rmi4/rmi_spi.c:507:26: error: 'rmi_spi_suspend' undeclared here (not in a function); did you mean 'rmi_driver_suspend'?
507 | SET_SYSTEM_SLEEP_PM_OPS(rmi_spi_suspend, rmi_spi_resume)
| ^~~~~~~~~~~~~~~
include/linux/kernel.h:41:38: note: in definition of macro 'PTR_IF'
41 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
| ^~~
include/linux/pm.h:308:14: note: in expansion of macro 'pm_sleep_ptr'
308 | .suspend = pm_sleep_ptr(suspend_fn), \
| ^~~~~~~~~~~~
drivers/input/rmi4/rmi_spi.c:507:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS'
507 | SET_SYSTEM_SLEEP_PM_OPS(rmi_spi_suspend, rmi_spi_resume)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/input/rmi4/rmi_spi.c:507:43: error: 'rmi_spi_resume' undeclared here (not in a function); did you mean 'rmi_spi_pm'?
507 | SET_SYSTEM_SLEEP_PM_OPS(rmi_spi_suspend, rmi_spi_resume)
| ^~~~~~~~~~~~~~
include/linux/kernel.h:41:38: note: in definition of macro 'PTR_IF'
41 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
| ^~~
include/linux/pm.h:309:14: note: in expansion of macro 'pm_sleep_ptr'
309 | .resume = pm_sleep_ptr(resume_fn), \
| ^~~~~~~~~~~~
drivers/input/rmi4/rmi_spi.c:507:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS'
507 | SET_SYSTEM_SLEEP_PM_OPS(rmi_spi_suspend, rmi_spi_resume)
| ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/input/rmi4/rmi_spi.c:508:21: error: 'rmi_spi_runtime_suspend' undeclared here (not in a function)
508 | SET_RUNTIME_PM_OPS(rmi_spi_runtime_suspend, rmi_spi_runtime_resume,
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:41:38: note: in definition of macro 'PTR_IF'
41 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
| ^~~
include/linux/pm.h:332:21: note: in expansion of macro 'pm_ptr'
332 | .runtime_suspend = pm_ptr(suspend_fn), \
| ^~~~~~
drivers/input/rmi4/rmi_spi.c:508:2: note: in expansion of macro 'SET_RUNTIME_PM_OPS'
508 | SET_RUNTIME_PM_OPS(rmi_spi_runtime_suspend, rmi_spi_runtime_resume,
| ^~~~~~~~~~~~~~~~~~
>> drivers/input/rmi4/rmi_spi.c:508:46: error: 'rmi_spi_runtime_resume' undeclared here (not in a function)
508 | SET_RUNTIME_PM_OPS(rmi_spi_runtime_suspend, rmi_spi_runtime_resume,
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:41:38: note: in definition of macro 'PTR_IF'
41 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
| ^~~
include/linux/pm.h:333:21: note: in expansion of macro 'pm_ptr'
333 | .runtime_resume = pm_ptr(resume_fn), \
| ^~~~~~
drivers/input/rmi4/rmi_spi.c:508:2: note: in expansion of macro 'SET_RUNTIME_PM_OPS'
508 | SET_RUNTIME_PM_OPS(rmi_spi_runtime_suspend, rmi_spi_runtime_resume,
| ^~~~~~~~~~~~~~~~~~
--
In file included from include/linux/list.h:9,
from include/linux/rculist.h:10,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from include/linux/backlight.h:12,
from drivers/video/backlight/ams369fg06.c:11:
>> drivers/video/backlight/ams369fg06.c:541:45: error: 'ams369fg06_suspend' undeclared here (not in a function); did you mean 'ams369fg06_probe'?
541 | static SIMPLE_DEV_PM_OPS(ams369fg06_pm_ops, ams369fg06_suspend,
| ^~~~~~~~~~~~~~~~~~
include/linux/kernel.h:41:38: note: in definition of macro 'PTR_IF'
41 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
| ^~~
include/linux/pm.h:308:14: note: in expansion of macro 'pm_sleep_ptr'
308 | .suspend = pm_sleep_ptr(suspend_fn), \
| ^~~~~~~~~~~~
include/linux/pm.h:342:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS'
342 | SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/video/backlight/ams369fg06.c:541:8: note: in expansion of macro 'SIMPLE_DEV_PM_OPS'
541 | static SIMPLE_DEV_PM_OPS(ams369fg06_pm_ops, ams369fg06_suspend,
| ^~~~~~~~~~~~~~~~~
>> drivers/video/backlight/ams369fg06.c:542:4: error: 'ams369fg06_resume' undeclared here (not in a function); did you mean 'ams369fg06_remove'?
542 | ams369fg06_resume);
| ^~~~~~~~~~~~~~~~~
include/linux/kernel.h:41:38: note: in definition of macro 'PTR_IF'
41 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
| ^~~
include/linux/pm.h:309:14: note: in expansion of macro 'pm_sleep_ptr'
309 | .resume = pm_sleep_ptr(resume_fn), \
| ^~~~~~~~~~~~
include/linux/pm.h:342:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS'
342 | SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/video/backlight/ams369fg06.c:541:8: note: in expansion of macro 'SIMPLE_DEV_PM_OPS'
541 | static SIMPLE_DEV_PM_OPS(ams369fg06_pm_ops, ams369fg06_suspend,
| ^~~~~~~~~~~~~~~~~
--
In file included from include/linux/delay.h:22,
from drivers/video/backlight/vgg2432a4.c:11:
>> drivers/video/backlight/vgg2432a4.c:246:44: error: 'vgg2432a4_suspend' undeclared here (not in a function); did you mean 'vgg2432a4_client'?
246 | static SIMPLE_DEV_PM_OPS(vgg2432a4_pm_ops, vgg2432a4_suspend, vgg2432a4_resume);
| ^~~~~~~~~~~~~~~~~
include/linux/kernel.h:41:38: note: in definition of macro 'PTR_IF'
41 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
| ^~~
include/linux/pm.h:308:14: note: in expansion of macro 'pm_sleep_ptr'
308 | .suspend = pm_sleep_ptr(suspend_fn), \
| ^~~~~~~~~~~~
include/linux/pm.h:342:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS'
342 | SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/video/backlight/vgg2432a4.c:246:8: note: in expansion of macro 'SIMPLE_DEV_PM_OPS'
246 | static SIMPLE_DEV_PM_OPS(vgg2432a4_pm_ops, vgg2432a4_suspend, vgg2432a4_resume);
| ^~~~~~~~~~~~~~~~~
>> drivers/video/backlight/vgg2432a4.c:246:63: error: 'vgg2432a4_resume' undeclared here (not in a function); did you mean 'vgg2432a4_remove'?
246 | static SIMPLE_DEV_PM_OPS(vgg2432a4_pm_ops, vgg2432a4_suspend, vgg2432a4_resume);
| ^~~~~~~~~~~~~~~~
include/linux/kernel.h:41:38: note: in definition of macro 'PTR_IF'
41 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
| ^~~
include/linux/pm.h:309:14: note: in expansion of macro 'pm_sleep_ptr'
309 | .resume = pm_sleep_ptr(resume_fn), \
| ^~~~~~~~~~~~
include/linux/pm.h:342:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS'
342 | SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/video/backlight/vgg2432a4.c:246:8: note: in expansion of macro 'SIMPLE_DEV_PM_OPS'
246 | static SIMPLE_DEV_PM_OPS(vgg2432a4_pm_ops, vgg2432a4_suspend, vgg2432a4_resume);
| ^~~~~~~~~~~~~~~~~
vim +/rmi_spi_runtime_suspend +508 drivers/input/rmi4/rmi_spi.c
8d99758dee31ff Andrew Duggan 2016-03-10 505
8d99758dee31ff Andrew Duggan 2016-03-10 506 static const struct dev_pm_ops rmi_spi_pm = {
8d99758dee31ff Andrew Duggan 2016-03-10 @507 SET_SYSTEM_SLEEP_PM_OPS(rmi_spi_suspend, rmi_spi_resume)
8d99758dee31ff Andrew Duggan 2016-03-10 @508 SET_RUNTIME_PM_OPS(rmi_spi_runtime_suspend, rmi_spi_runtime_resume,
8d99758dee31ff Andrew Duggan 2016-03-10 509 NULL)
8d99758dee31ff Andrew Duggan 2016-03-10 510 };
8d99758dee31ff Andrew Duggan 2016-03-10 511
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (31298 bytes)
Powered by blists - more mailing lists