linux-kernel - Re: [PATCH 2/2] pm: allow drivers to drop #ifdef and __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Apr 2021 07:55:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Masahiro Yamada <masahiroy@...nel.org>,
        linux-kbuild@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, linux-gpio@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        Paul Cercueil <paul@...pouillou.net>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/2] pm: allow drivers to drop #ifdef and __maybe_unused
 from pm callbacks

Hi Masahiro,

I love your patch! Yet something to improve:

[auto build test ERROR on pinctrl/devel]
[also build test ERROR on pm/linux-next soc/for-next linus/master v5.12-rc6]
[cannot apply to next-20210408]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Masahiro-Yamada/linux-kconfig-h-move-IF_ENABLED-out-of-linux-kconfig-h/20210409-050128
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: xtensa-randconfig-r023-20210408 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/01dfb9e1a54c14b3f491c3a5e93f1e8756042567
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Masahiro-Yamada/linux-kconfig-h-move-IF_ENABLED-out-of-linux-kconfig-h/20210409-050128
        git checkout 01dfb9e1a54c14b3f491c3a5e93f1e8756042567
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/delay.h:22,
                    from sound/pci/hda/hda_intel.c:23:
>> sound/pci/hda/hda_intel.c:1182:26: error: 'azx_suspend' undeclared here (not in a function)
    1182 |  SET_SYSTEM_SLEEP_PM_OPS(azx_suspend, azx_resume)
         |                          ^~~~~~~~~~~
   include/linux/kernel.h:41:38: note: in definition of macro 'PTR_IF'
      41 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
         |                                      ^~~
   include/linux/pm.h:308:14: note: in expansion of macro 'pm_sleep_ptr'
     308 |  .suspend  = pm_sleep_ptr(suspend_fn), \
         |              ^~~~~~~~~~~~
   sound/pci/hda/hda_intel.c:1182:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS'
    1182 |  SET_SYSTEM_SLEEP_PM_OPS(azx_suspend, azx_resume)
         |  ^~~~~~~~~~~~~~~~~~~~~~~
>> sound/pci/hda/hda_intel.c:1182:39: error: 'azx_resume' undeclared here (not in a function)
    1182 |  SET_SYSTEM_SLEEP_PM_OPS(azx_suspend, azx_resume)
         |                                       ^~~~~~~~~~
   include/linux/kernel.h:41:38: note: in definition of macro 'PTR_IF'
      41 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
         |                                      ^~~
   include/linux/pm.h:309:14: note: in expansion of macro 'pm_sleep_ptr'
     309 |  .resume   = pm_sleep_ptr(resume_fn), \
         |              ^~~~~~~~~~~~
   sound/pci/hda/hda_intel.c:1182:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS'
    1182 |  SET_SYSTEM_SLEEP_PM_OPS(azx_suspend, azx_resume)
         |  ^~~~~~~~~~~~~~~~~~~~~~~


vim +/azx_suspend +1182 sound/pci/hda/hda_intel.c

6eb827d23577a4 Takashi Iwai  2012-12-12  1180  
b8dfc4624162c0 Mengdong Lin  2012-08-23  1181  static const struct dev_pm_ops azx_pm = {
b8dfc4624162c0 Mengdong Lin  2012-08-23 @1182  	SET_SYSTEM_SLEEP_PM_OPS(azx_suspend, azx_resume)
3e6db33aaf1d42 Xiong Zhang   2015-12-18  1183  #ifdef CONFIG_PM_SLEEP
f5dac54d9d9382 Kai-Heng Feng 2020-10-27  1184  	.prepare = azx_prepare,
f5dac54d9d9382 Kai-Heng Feng 2020-10-27  1185  	.complete = azx_complete,
3e6db33aaf1d42 Xiong Zhang   2015-12-18  1186  	.freeze_noirq = azx_freeze_noirq,
3e6db33aaf1d42 Xiong Zhang   2015-12-18  1187  	.thaw_noirq = azx_thaw_noirq,
3e6db33aaf1d42 Xiong Zhang   2015-12-18  1188  #endif
6eb827d23577a4 Takashi Iwai  2012-12-12  1189  	SET_RUNTIME_PM_OPS(azx_runtime_suspend, azx_runtime_resume, azx_runtime_idle)
b8dfc4624162c0 Mengdong Lin  2012-08-23  1190  };
b8dfc4624162c0 Mengdong Lin  2012-08-23  1191  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (26505 bytes)