linux-kernel - Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c478c9b-fc2a-2dd7-6191-8f68e265c2f7@hisilicon.com>
Date:   Thu, 8 Apr 2021 15:17:07 +0800
From:   Yicong Yang <yangyicong@...ilicon.com>
To:     Wolfram Sang <wsa@...nel.org>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        <andriy.shevchenko@...ux.intel.com>, <linux-i2c@...r.kernel.org>,
        <Sergey.Semin@...kalelectronics.ru>,
        <linux-kernel@...r.kernel.org>, <digetx@...il.com>,
        <treding@...dia.com>, <rmk+kernel@...linux.org.uk>,
        <song.bao.hua@...ilicon.com>, <john.garry@...wei.com>,
        <mika.westerberg@...ux.intel.com>, <prime.zeng@...wei.com>,
        <linuxarm@...wei.com>
Subject: Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller

On 2021/4/8 7:04, Wolfram Sang wrote:
> 
>> Reason for temp variable is for me it's confusing to see statement like
>> "rate_khz = rate_khz / 1000".
> 
> Yes. And with this clearer calculation, we can maybe skip the HZ_PER_KHZ
> define completely and just use plain '1000' as a factor/divider because
> it then becomes obvious. I still find the define more confusing than
> helpful TBH. But I'll leave the final decision to Yicong Yang.
> 

HZ_PER_KHZ macro are defined separately in other places of the kernel.
Andy suggested to have this defined and used so that one day we can factor
this macro out to the public. :)