linux-kernel - Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vfpg4zdSM2eXe8yFsMAJUea_NSjvMRgxqYOF2nDvZA1wg@mail.gmail.com>
Date:   Thu, 8 Apr 2021 12:43:36 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Yicong Yang <yangyicong@...ilicon.com>
Cc:     Wolfram Sang <wsa@...nel.org>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Sergey Semin <Sergey.Semin@...kalelectronics.ru>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dmitry Osipenko <digetx@...il.com>,
        Thierry Reding <treding@...dia.com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Barry Song <song.bao.hua@...ilicon.com>,
        John Garry <john.garry@...wei.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        prime.zeng@...wei.com, Linuxarm <linuxarm@...wei.com>
Subject: Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller

On Thu, Apr 8, 2021 at 10:17 AM Yicong Yang <yangyicong@...ilicon.com> wrote:
> On 2021/4/8 7:04, Wolfram Sang wrote:
> >
> >> Reason for temp variable is for me it's confusing to see statement like
> >> "rate_khz = rate_khz / 1000".
> >
> > Yes. And with this clearer calculation, we can maybe skip the HZ_PER_KHZ
> > define completely and just use plain '1000' as a factor/divider because
> > it then becomes obvious. I still find the define more confusing than
> > helpful TBH. But I'll leave the final decision to Yicong Yang.
> >
>
> HZ_PER_KHZ macro are defined separately in other places of the kernel.
> Andy suggested to have this defined and used so that one day we can factor
> this macro out to the public. :)

Right, and I'm still for the idea to have a macro defined.

-- 
With Best Regards,
Andy Shevchenko