[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75Vf1S5Ra4fdkV=faw4tCXbeNiifC3y8MF0_bCqHGfDBLsQ@mail.gmail.com>
Date: Thu, 8 Apr 2021 12:47:13 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Naresh Kamboju <naresh.kamboju@...aro.org>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
Linux-Next Mailing List <linux-next@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
lkft-triage@...ts.linaro.org,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@...r.kernel.org>,
Stephen Rothwell <sfr@...b.auug.org.au>,
Arnd Bergmann <arnd@...db.de>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Colin King <colin.king@...onical.com>,
Christian Brauner <christian.brauner@...ntu.com>,
Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [next] [arm64] [gpio] BUG: key has not been registered! DEBUG_LOCKS_WARN_ON:
On Thu, Apr 8, 2021 at 11:33 AM Naresh Kamboju
<naresh.kamboju@...aro.org> wrote:
> On Thu, 8 Apr 2021 at 04:21, Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> > On Thu, Apr 8, 2021 at 12:38 AM Naresh Kamboju
> > <naresh.kamboju@...aro.org> wrote:
> > >
> > > While running kselftest recently added gpio gpio-sim.sh test case the following
> > > warning was triggered on Linux next tag 20210330 tag running on arm64 juno
> > > and hikey devices.
> > >
> > > GOOD: next-20210326
> > > BAD: next-20210330
> > >
> > > This is still happening today on Linux next tag 20210407.
> >
> > Can you add the following
> >
> > sysfs_attr_init(attrs[i]);
> >
> > to the end of the loop in gpio_sim_setup_sysfs()?
>
> Do you mean like this,
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index ea17289a869c..5fe67ccf45f7 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -296,6 +296,7 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip)
> dev_attr->store = gpio_sim_sysfs_line_store;
>
> attrs[i] = &dev_attr->attr;
> + sysfs_attr_init(attrs[i]);
> }
>
> chip->attr_group.name = "line-ctrl";
Precisely.
> > If it fixes an issue I'll send a formal patch.
>
> I will build and test this and report here.
Thanks!
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists