linux-kernel - Re: [Outreachy kernel] [PATCH] staging: rtl8712: added spaces around '+'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Apr 2021 16:55:45 +0530
From:   Mitali Borkar <mitaliborkar810@...il.com>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com,
        mitali_s@...iitr.ac.in
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8712: added spaces around
 '+'

On Thu, Apr 08, 2021 at 10:30:09AM +0200, Julia Lawall wrote:
> The subject line should be in the imperative, so "add" instead of "added".
> 
Ok Ma'am
> On Thu, 8 Apr 2021, Mitali Borkar wrote:
> 
> > Clean up Check:spaces preferred around that '+' (ctx:VxV)
> > Reported by checkpatch
> 
> Please try to rephrase to explain what you did and why.  "Clean up" kind
> of states what the goal is, but your opinion about what is a clean up
> might be different than someone else's.  It's also not necessary to cite
> the checkpatch warning exactly.
> 
OKay Ma'am, will rewrite the appopriate commit message. May I know while
resending this patch, what should I write in subject description, 
RESEND PATCH or PATCH v2

Thanks
Mitali

> julia
> 
> >
> > Signed-off-by: Mitali Borkar <mitaliborkar810@...il.com>
> > ---
> >  drivers/staging/rtl8712/wlan_bssdef.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
> > index b54ccaacc527..ec3749813728 100644
> > --- a/drivers/staging/rtl8712/wlan_bssdef.h
> > +++ b/drivers/staging/rtl8712/wlan_bssdef.h
> > @@ -176,7 +176,7 @@ struct NDIS_802_11_WEP {
> >  #define MIC_CHECK_TIME	60000000
> >
> >  #ifndef Ndis802_11APMode
> > -#define Ndis802_11APMode (Ndis802_11InfrastructureMax+1)
> > +#define Ndis802_11APMode (Ndis802_11InfrastructureMax + 1)
> >  #endif
> >
> >  struct	wlan_network {
> > --
> > 2.30.2
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YG690ZIRdCEcjoM6%40kali.
> >