linux-kernel - Re: [Outreachy kernel] [PATCH] staging: rtl8712: added spaces around '+'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Apr 2021 13:34:38 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mitali Borkar <mitaliborkar810@...il.com>
Cc:     Julia Lawall <julia.lawall@...ia.fr>, Larry.Finger@...inger.net,
        florian.c.schilhabel@...glemail.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com,
        mitali_s@...iitr.ac.in
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8712: added spaces around
 '+'

On Thu, Apr 08, 2021 at 04:55:45PM +0530, Mitali Borkar wrote:
> On Thu, Apr 08, 2021 at 10:30:09AM +0200, Julia Lawall wrote:
> > The subject line should be in the imperative, so "add" instead of "added".
> > 
> Ok Ma'am
> > On Thu, 8 Apr 2021, Mitali Borkar wrote:
> > 
> > > Clean up Check:spaces preferred around that '+' (ctx:VxV)
> > > Reported by checkpatch
> > 
> > Please try to rephrase to explain what you did and why.  "Clean up" kind
> > of states what the goal is, but your opinion about what is a clean up
> > might be different than someone else's.  It's also not necessary to cite
> > the checkpatch warning exactly.
> > 
> OKay Ma'am, will rewrite the appopriate commit message. May I know while
> resending this patch, what should I write in subject description, 
> RESEND PATCH or PATCH v2

"RESEND" is only ok if the patch and changelog text is identical to the
previous version and something got lost so it needed to be resent.

I do not think that is the case here.

thanks,

greg k-h