[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210408113140.103032-1-wangwensheng4@huawei.com>
Date: Thu, 8 Apr 2021 11:31:40 +0000
From: Wang Wensheng <wangwensheng4@...wei.com>
To: <mike.marciniszyn@...nelisnetworks.com>,
<dennis.dalessandro@...nelisnetworks.com>, <dledford@...hat.com>,
<jgg@...pe.ca>, <brendan.cunningham@...el.com>,
<ira.weiny@...el.com>, <sudeep.dutt@...el.com>,
<linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <rui.xiang@...wei.com>
Subject: [PATCH -next] IB/hfi1: Fix error return code in parse_platform_config()
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 7724105686e7 ("IB/hfi1: add driver files")
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Wang Wensheng <wangwensheng4@...wei.com>
---
drivers/infiniband/hw/hfi1/firmware.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/hfi1/firmware.c b/drivers/infiniband/hw/hfi1/firmware.c
index 0e83d4b..2cf102b 100644
--- a/drivers/infiniband/hw/hfi1/firmware.c
+++ b/drivers/infiniband/hw/hfi1/firmware.c
@@ -1916,6 +1916,7 @@ int parse_platform_config(struct hfi1_devdata *dd)
dd_dev_err(dd, "%s: Failed CRC check at offset %ld\n",
__func__, (ptr -
(u32 *)dd->platform_config.data));
+ ret = -EINVAL;
goto bail;
}
/* Jump the CRC DWORD */
--
2.9.4
Powered by blists - more mailing lists