[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YG8IoWznJEzwfigA@smile.fi.intel.com>
Date: Thu, 8 Apr 2021 16:44:01 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Syed Nayyar Waris <syednwaris@...il.com>
Cc: bgolaszewski@...libre.com, vilhelm.gray@...il.com,
michal.simek@...inx.com, arnd@...db.de, rrichter@...vell.com,
linus.walleij@...aro.org, yamada.masahiro@...ionext.com,
akpm@...ux-foundation.org, rui.zhang@...el.com,
daniel.lezcano@...aro.org, amit.kucheria@...durent.com,
linux-arch@...r.kernel.org, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-pm@...r.kernel.org
Subject: Re: [RESEND PATCH v4 3/3] gpio: xilinx: Utilize generic
bitmap_get_value and _set_value
On Fri, Apr 02, 2021 at 10:07:36PM +0530, Syed Nayyar Waris wrote:
> This patch reimplements the xgpio_set_multiple() function in
> drivers/gpio/gpio-xilinx.c to use the new generic functions:
> bitmap_get_value() and bitmap_set_value(). The code is now simpler
> to read and understand. Moreover, instead of looping for each bit
> in xgpio_set_multiple() function, now we can check each channel at
> a time and save cycles.
As promised, I have looked at this with a fresh eye and NAK from me. Sorry.
This is less than a half baked solution. I spent couple of evenings, so
I'll come up with full conversion of this driver to the bitmap API.
And yes, as I have told you like half a year before, bitmap_get_value32() and
bitmap_set_value32() is much more useful (and I actually implemented them
locally for the sake of conversion).
So, summarize this I do not think we have real users of the proposed API.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists