linux-kernel - Re: [PATCH v4] lib/string: Introduce sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJX1Yta1nd-xMwzsFvk50RzWY_6CMbgfE-LH-SCQvPGdxDJ8pQ@mail.gmail.com>
Date:   Thu, 8 Apr 2021 16:52:02 +0200
From:   Gioh Kim <gi-oh.kim@...os.com>
To:     Jinpu Wang <jinpu.wang@...os.com>
Cc:     open list <linux-kernel@...r.kernel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Dan Williams <dan.j.williams@...el.com>,
        laniel_francis@...vacyrequired.com,
        Kees Cook <keescook@...omium.org>,
        Daniel Axtens <dja@...ens.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Haris Iqbal <haris.iqbal@...os.com>
Subject: Re: [PATCH v4] lib/string: Introduce sysfs_streqcase

On Thu, Apr 8, 2021 at 3:14 PM Jinpu Wang <jinpu.wang@...os.com> wrote:
>
> On Thu, Apr 8, 2021 at 3:06 PM Gioh Kim <gi-oh.kim@...os.com> wrote:
> >
> > As the name shows, it checks if strings are equal in case insensitive
> > manner.
> >
> > For example, drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c uses
> > strncasecmp to check that the input via sysfs is "mi". But it would
> > work even-if the input is "min-wrongcommand".
> >
> > I found some more cases using strncasecmp to check the entire string
> > such as rtrs-clt-sysfs.c does. drivers/pnp/interface.c checks
> > "disable" command with strncasecmp but it would also work if the
> > command is "disable-wrong".
> >
> > Signed-off-by: Gioh Kim <gi-oh.kim@...os.com>
> you should add the
> Reported-by: kernel test robot <lkp@...el.com>
> > ---
> you can add the changelog here after the ---
> v4->v3:  removed #ifdef CONFIG_SYSFS ~ #endif.
>
> The string comparison doesn't depends on CONFIG_SYSFS at all.
>
> It looks good to me.
> Reviewed-by: Jack Wang <jinpu.wang@...os.com>
>
>

Yes, I got two build error reports for v3.
Should I send v5 including "Reported-by: kernel test robot <lkp@...el.com>" tag?