[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YG8Y1HexwyN2Wk03@kroah.com>
Date: Thu, 8 Apr 2021 16:53:08 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Longfang Liu <liulongfang@...wei.com>
Cc: mathias.nyman@...el.com, stern@...land.harvard.edu,
liudongdong3@...wei.com, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, kong.kongxinwei@...ilicon.com,
yisen.zhuang@...wei.com
Subject: Re: [PATCH v2 1/2] USB:ehci:Add a whitelist for EHCI controllers
On Thu, Apr 08, 2021 at 09:49:19PM +0800, Longfang Liu wrote:
> Some types of EHCI controllers do not have SBRN registers.
> By comparing the white list, the operation of reading the SBRN
> registers is skipped.
>
> Subsequent EHCI controller types without SBRN registers can be
> directly added to the white list.
>
> The current patch does not affect the drive function.
>
> Signed-off-by: Longfang Liu <liulongfang@...wei.com>
> ---
> drivers/usb/host/ehci-pci.c | 28 ++++++++++++++++++++++++----
> 1 file changed, 24 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> index 3c3820a..534e906 100644
> --- a/drivers/usb/host/ehci-pci.c
> +++ b/drivers/usb/host/ehci-pci.c
> @@ -47,6 +47,29 @@ static inline bool is_bypassed_id(struct pci_dev *pdev)
> return !!pci_match_id(bypass_pci_id_table, pdev);
> }
>
> +static const struct usb_nosbrn_whitelist_entry {
Again, please do not use the term "whitelist", it is vague and you can
pick a better term for this.
How about:
struct ehci_nosbrn;
thanks,
greg k-h
Powered by blists - more mailing lists