linux-kernel - Re: [PATCH -next] lib: zstd: Make symbol 'HUF_compressWeights

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72k-X2WPfi7B2sNYMUqAEPjZq5yp4R+j5V6gxMx+AiOq_w@mail.gmail.com>
Date:   Fri, 9 Apr 2021 05:09:10 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Zhao Xuehui <zhaoxuehui1@...wei.com>,
        Nick Terrell <terrelln@...com>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Miguel Ojeda <ojeda@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, yangjihong1@...wei.com,
        zhangjinhao2@...wei.com
Subject: Re: [PATCH -next] lib: zstd: Make symbol 'HUF_compressWeights_wksp' static

On Fri, Apr 9, 2021 at 2:20 AM Nick Desaulniers <ndesaulniers@...gle.com> wrote:
>
> Quite a few other functions are declared in a header, but I don't see
> any existing callers in tree.  I wonder if the maintainer could
> consider cleaning these up so that we don't retain them in binaries
> without dead code elimination enabled, or if there's a need to keep
> this code in line with an external upstream codebase?

Yeah, the equivalent cleanup was done upstream by Nick in 2018 [1],
but there has been no major update to lib/zstd since 2017.

Thus a cleanup would actually make it closer to upstream, which is the
best case scenario :)

    Reviewed-by: Miguel Ojeda <ojeda@...nel.org>

[1] https://github.com/facebook/zstd/commit/f2d6db45cd28457fa08467416e8535985f062859

Cheers,
Miguel