linux-kernel - Re: [PATCH -next] lib: zstd: Make symbol 'HUF_compressWeights

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17D84680-A287-468A-B4EA-E8E037B587D8@fb.com>
Date:   Fri, 9 Apr 2021 21:42:29 +0000
From:   Nick Terrell <terrelln@...com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
CC:     Nick Desaulniers <ndesaulniers@...gle.com>,
        Zhao Xuehui <zhaoxuehui1@...wei.com>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Miguel Ojeda <ojeda@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "yangjihong1@...wei.com" <yangjihong1@...wei.com>,
        "zhangjinhao2@...wei.com" <zhangjinhao2@...wei.com>
Subject: Re: [PATCH -next] lib: zstd: Make symbol 'HUF_compressWeights_wksp'
 static



> On Apr 8, 2021, at 8:09 PM, Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote:
> 
> On Fri, Apr 9, 2021 at 2:20 AM Nick Desaulniers <ndesaulniers@...gle.com> wrote:
>> 
>> Quite a few other functions are declared in a header, but I don't see
>> any existing callers in tree.  I wonder if the maintainer could
>> consider cleaning these up so that we don't retain them in binaries
>> without dead code elimination enabled, or if there's a need to keep
>> this code in line with an external upstream codebase?
> 
> Yeah, the equivalent cleanup was done upstream by Nick in 2018 [1],
> but there has been no major update to lib/zstd since 2017.
> 
> Thus a cleanup would actually make it closer to upstream, which is the
> best case scenario :)
> 
>    Reviewed-by: Miguel Ojeda <ojeda@...nel.org>
> 
> [1] https://github.com/facebook/zstd/commit/f2d6db45cd28457fa08467416e8535985f062859

This looks good to me as well. I have a patchset up to use upstream zstd directly in the kernel [0].
That will allow us to keep zstd up to date. And after that lands, I hope to set up a zstd linux tree
to make merging patches into lib/zstd easier, since over the years quite a few have been ignored.

[0] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2532407.html

Best,
Nick Terrell

> Cheers,
> Miguel