| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <dc60e7f4-1513-5c8e-0ad2-7671a2cb02de@gmail.com>
Date: Fri, 9 Apr 2021 03:16:57 +0300
From: Dmitry Osipenko <digetx@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-tegra@...r.kernel.org
Subject: Re: [PATCH v3 1/1] dt-bindings: memory: tegra20: emc: Convert to
schema
08.04.2021 23:29, Rob Herring пишет:
> On Sun, Apr 04, 2021 at 06:55:01PM +0300, Dmitry Osipenko wrote:
>> Convert Tegra20 External Memory Controller binding to schema.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
>> ---
>> .../memory-controllers/nvidia,tegra20-emc.txt | 130 --------
>> .../nvidia,tegra20-emc.yaml | 303 ++++++++++++++++++
>> 2 files changed, 303 insertions(+), 130 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt
>> create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt
>> deleted file mode 100644
>> index d2250498c36d..000000000000
>> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt
>> +++ /dev/null
>> @@ -1,130 +0,0 @@
>> -Embedded Memory Controller
>> -
>> -Properties:
>> -- name : Should be emc
>> -- #address-cells : Should be 1
>> -- #size-cells : Should be 0
>> -- compatible : Should contain "nvidia,tegra20-emc".
>> -- reg : Offset and length of the register set for the device
>> -- nvidia,use-ram-code : If present, the sub-nodes will be addressed
>> - and chosen using the ramcode board selector. If omitted, only one
>> - set of tables can be present and said tables will be used
>> - irrespective of ram-code configuration.
>> -- interrupts : Should contain EMC General interrupt.
>> -- clocks : Should contain EMC clock.
>> -- nvidia,memory-controller : Phandle of the Memory Controller node.
>> -- #interconnect-cells : Should be 0.
>> -- operating-points-v2: See ../bindings/opp/opp.txt for details.
>> -
>> -For each opp entry in 'operating-points-v2' table:
>> -- opp-supported-hw: One bitfield indicating SoC process ID mask
>> -
>> - A bitwise AND is performed against this value and if any bit
>> - matches, the OPP gets enabled.
>> -
>> -Optional properties:
>> -- power-domains: Phandle of the SoC "core" power domain.
>> -
>> -Child device nodes describe the memory settings for different configurations and clock rates.
>> -
>> -Example:
>> -
>> - opp_table: opp-table {
>> - compatible = "operating-points-v2";
>> -
>> - opp@...00000 {
>> - opp-microvolt = <950000 950000 1300000>;
>> - opp-hz = /bits/ 64 <36000000>;
>> - };
>> - ...
>> - };
>> -
>> - memory-controller@...0f400 {
>> - #address-cells = < 1 >;
>> - #size-cells = < 0 >;
>> - #interconnect-cells = <0>;
>> - compatible = "nvidia,tegra20-emc";
>> - reg = <0x7000f400 0x400>;
>> - interrupts = <0 78 0x04>;
>> - clocks = <&tegra_car TEGRA20_CLK_EMC>;
>> - nvidia,memory-controller = <&mc>;
>> - power-domains = <&domain>;
>> - operating-points-v2 = <&opp_table>;
>> - }
>> -
>> -
>> -Embedded Memory Controller ram-code table
>> -
>> -If the emc node has the nvidia,use-ram-code property present, then the
>> -next level of nodes below the emc table are used to specify which settings
>> -apply for which ram-code settings.
>> -
>> -If the emc node lacks the nvidia,use-ram-code property, this level is omitted
>> -and the tables are stored directly under the emc node (see below).
>> -
>> -Properties:
>> -
>> -- name : Should be emc-tables
>> -- nvidia,ram-code : the binary representation of the ram-code board strappings
>> - for which this node (and children) are valid.
>> -
>> -
>> -
>> -Embedded Memory Controller configuration table
>> -
>> -This is a table containing the EMC register settings for the various
>> -operating speeds of the memory controller. They are always located as
>> -subnodes of the emc controller node.
>> -
>> -There are two ways of specifying which tables to use:
>> -
>> -* The simplest is if there is just one set of tables in the device tree,
>> - and they will always be used (based on which frequency is used).
>> - This is the preferred method, especially when firmware can fill in
>> - this information based on the specific system information and just
>> - pass it on to the kernel.
>> -
>> -* The slightly more complex one is when more than one memory configuration
>> - might exist on the system. The Tegra20 platform handles this during
>> - early boot by selecting one out of possible 4 memory settings based
>> - on a 2-pin "ram code" bootstrap setting on the board. The values of
>> - these strappings can be read through a register in the SoC, and thus
>> - used to select which tables to use.
>> -
>> -Properties:
>> -- name : Should be emc-table
>> -- compatible : Should contain "nvidia,tegra20-emc-table".
>> -- reg : either an opaque enumerator to tell different tables apart, or
>> - the valid frequency for which the table should be used (in kHz).
>> -- clock-frequency : the clock frequency for the EMC at which this
>> - table should be used (in kHz).
>> -- nvidia,emc-registers : a 46 word array of EMC registers to be programmed
>> - for operation at the 'clock-frequency' setting.
>> - The order and contents of the registers are:
>> - RC, RFC, RAS, RP, R2W, W2R, R2P, W2P, RD_RCD, WR_RCD, RRD, REXT,
>> - WDV, QUSE, QRST, QSAFE, RDV, REFRESH, BURST_REFRESH_NUM, PDEX2WR,
>> - PDEX2RD, PCHG2PDEN, ACT2PDEN, AR2PDEN, RW2PDEN, TXSR, TCKE, TFAW,
>> - TRPAB, TCLKSTABLE, TCLKSTOP, TREFBW, QUSE_EXTRA, FBIO_CFG6, ODT_WRITE,
>> - ODT_READ, FBIO_CFG5, CFG_DIG_DLL, DLL_XFORM_DQS, DLL_XFORM_QUSE,
>> - ZCAL_REF_CNT, ZCAL_WAIT_CNT, AUTO_CAL_INTERVAL, CFG_CLKTRIM_0,
>> - CFG_CLKTRIM_1, CFG_CLKTRIM_2
>> -
>> - emc-table@...000 {
>> - reg = <166000>;
>> - compatible = "nvidia,tegra20-emc-table";
>> - clock-frequency = < 166000 >;
>> - nvidia,emc-registers = < 0 0 0 0 0 0 0 0 0 0 0 0 0 0
>> - 0 0 0 0 0 0 0 0 0 0 0 0 0 0
>> - 0 0 0 0 0 0 0 0 0 0 0 0 0 0
>> - 0 0 0 0 >;
>> - };
>> -
>> - emc-table@...000 {
>> - reg = <333000>;
>> - compatible = "nvidia,tegra20-emc-table";
>> - clock-frequency = < 333000 >;
>> - nvidia,emc-registers = < 0 0 0 0 0 0 0 0 0 0 0 0 0 0
>> - 0 0 0 0 0 0 0 0 0 0 0 0 0 0
>> - 0 0 0 0 0 0 0 0 0 0 0 0 0 0
>> - 0 0 0 0 >;
>> - };
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> new file mode 100644
>> index 000000000000..f4ccfa85d5fb
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> @@ -0,0 +1,303 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/memory-controllers/nvidia,tegra20-emc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: NVIDIA Tegra20 SoC External Memory Controller
>> +
>> +maintainers:
>> + - Dmitry Osipenko <digetx@...il.com>
>> + - Jon Hunter <jonathanh@...dia.com>
>> + - Thierry Reding <thierry.reding@...il.com>
>> +
>> +description: |
>> + The External Memory Controller (EMC) interfaces with the off-chip SDRAM to
>> + service the request stream sent from Memory Controller. The EMC also has
>> + various performance-affecting settings beyond the obvious SDRAM configuration
>> + parameters and initialization settings. Tegra20 EMC supports multiple JEDEC
>> + standard protocols: DDR1, LPDDR2 and DDR2.
>> +
>> +properties:
>> + compatible:
>> + const: nvidia,tegra20-emc
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + "#address-cells":
>> + const: 1
>> +
>> + "#size-cells":
>> + const: 0
>> +
>> + "#interconnect-cells":
>> + const: 0
>> +
>> + nvidia,memory-controller:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + Phandle of the Memory Controller node.
>> +
>> + power-domains:
>> + maxItems: 1
>> + description:
>> + Phandle of the SoC "core" power domain.
>> +
>> + operating-points-v2:
>> + description:
>> + Should contain freqs and voltages and opp-supported-hw property, which
>> + is a bitfield indicating SoC process ID mask.
>> +
>> + nvidia,use-ram-code:
>> + type: boolean
>> + description:
>> + If present, the emc-tables@ sub-nodes will be addressed.
>> +
>> +patternProperties:
>> + "^emc-table@[0-9]+$":
>
> Duplicating this can be avoided. Change this to:
>
> $defs:
> emc-table:
>
>
> And then do:
>
> patternProperties:
> "^emc-table@[0-9]+$":
> $ref: #/$defs/emc-table
>
> And the same later on.
Thank you, I'll try that variant.
Powered by blists - more mailing lists