linux-kernel - Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39dd50a7-6e85-49e4-8072-e88fcc471714@foss.st.com>
Date:   Fri, 9 Apr 2021 09:42:03 +0200
From:   Patrice CHOTARD <patrice.chotard@...s.st.com>
To:     Laibin Qiu <qiulaibin@...wei.com>, <adrian.hunter@...el.com>,
        <ulf.hansson@...aro.org>, <yuehaibing@...wei.com>
CC:     <linux-mmc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log

Hi Laibin

On 4/9/21 4:38 AM, Laibin Qiu wrote:
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@...wei.com>
> ---
>  drivers/mmc/host/sdhci-st.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 78941ac3a1d6..d41582c21aa3 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev)
>  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>  					   "top-mmc-delay");
>  	pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
> -	if (IS_ERR(pdata->top_ioaddr)) {
> -		dev_warn(&pdev->dev, "FlashSS Top Dly registers not available");
> +	if (IS_ERR(pdata->top_ioaddr))
>  		pdata->top_ioaddr = NULL;
> -	}
>  
>  	pltfm_host->clk = clk;
>  	pdata->icnclk = icnclk;
> 

Reviewed-by: Patrice Chotard <patrice.chotard@...s.st.com>

Thanks
Patrice