linux-kernel - Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFqbvZot3mFiManMaZtZw8Cuau-4ewOJSVBdR-MeZU-JwA@mail.gmail.com>
Date:   Mon, 12 Apr 2021 09:52:25 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Laibin Qiu <qiulaibin@...wei.com>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        patrice.chotard@...s.st.com, YueHaibing <yuehaibing@...wei.com>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log

On Fri, 9 Apr 2021 at 04:28, Laibin Qiu <qiulaibin@...wei.com> wrote:
>
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@...wei.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-st.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 78941ac3a1d6..d41582c21aa3 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev)
>         res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>                                            "top-mmc-delay");
>         pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
> -       if (IS_ERR(pdata->top_ioaddr)) {
> -               dev_warn(&pdev->dev, "FlashSS Top Dly registers not available");
> +       if (IS_ERR(pdata->top_ioaddr))
>                 pdata->top_ioaddr = NULL;
> -       }
>
>         pltfm_host->clk = clk;
>         pdata->icnclk = icnclk;
> --
> 2.25.1
>